[jboss-jira] [JBoss JIRA] Closed: (JBREM-648) Client.disconnect without clearing ConnectionListeners will cause NPEs

[David Lloyd (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBREM-648?page=all ]

David Lloyd closed JBREM-648.
-----------------------------


> Client.disconnect without clearing ConnectionListeners will cause NPEs
> ----------------------------------------------------------------------
>
>                 Key: JBREM-648
>                 URL: http://jira.jboss.com/jira/browse/JBREM-648
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.2.0.Alpha4
>            Reporter: Clebert Suconic
>         Assigned To: Tom  Elrod
>            Priority: Critical
>             Fix For:  2.2.0.Beta1 (Bluto)
>
>         Attachments: Client.java, ConnectionValidator.java
>
>
> ConnectionValidator should be stoped when disconnected is called.
> ConnectionValidator::run will fail at this line if ConnectionValidator is not stopped:
>    public void run()
>    {
>       try
>       {
>          boolean isValid = checkConnection(client.getInvoker().getLocator(), client.getConfiguration());
> The fix should be simple though:
>    public void disconnect()
>    {
>       if (invoker != null)
>       {
>          if(enableLease)
>          {
>             invoker.terminateLease(sessionId);
>             enableLease = false;
>          }
>          if (validator!=null) // /this is the fix.....
>          {
>               validator.stop();
>          }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira