[jboss-jira] [JBoss JIRA] Commented: (JBAOP-560) When an AspectFactory returns null no interceptor should be added to the chain

Mon Apr 21 09:51:44 EDT 2008

    [ http://jira.jboss.com/jira/browse/JBAOP-560?page=comments#action_12409789 ] 

Flavia Rainone commented on JBAOP-560:
--------------------------------------

On generated advisor mode, we need to check how we are going to do this. Since the calls to advices is hard coded, we will need either an if statement to check if the aspect is null before calling the advice, or we will need to create dummy aspects.
I wonder what would affect less the performance: calling a dummy advice, or having the extra cost of a check for null for each aspect every time the intercepted joinpoint gets invoked.
We need to take into account how frequent is this feature going to be used. If it will be rarely used (i.e., only a few scenarios), I vote for the dummy aspect, because this is not going to affect the performance of the common scenario, where the factories return non-null aspects.

> When an AspectFactory returns null no interceptor should be added to the chain
> ------------------------------------------------------------------------------
>
>                 Key: JBAOP-560
>                 URL: http://jira.jboss.com/jira/browse/JBAOP-560
>             Project: JBoss AOP
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.0.0.CR8
>            Reporter: Carlo de Wolf
>         Assigned To: Flavia Rainone
>             Fix For: 2.0.0.GA
>
>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira