[jboss-jira] [JBoss JIRA] Created: (JBMICROCONT-332) Logic error when checking controller context has no dependencies

Fri Aug 8 10:26:50 EDT 2008

Logic error when checking controller context has no dependencies
----------------------------------------------------------------

                 Key: JBMICROCONT-332
                 URL: https://jira.jboss.org/jira/browse/JBMICROCONT-332
             Project: JBoss MicroContainer
          Issue Type: Bug
          Components: Dependency
    Affects Versions: JBossMC.2.0.0.Beta16
            Reporter: Adrian Brock
            Assignee: Adrian Brock
             Fix For: JBossMC.2.0.0.CR1

There is a logic error in AbstractController when a ControllerContext has no dependencies

if (dependencies != null && dependencies.resolveDependencies(this, state))
  result.add(ctx);

Where result is the set of contexts that are eligible to advance to the next level.

This should of course be:
if (dependencies == null || dependencies.resolveDependencies(this, state))
  result.add(ctx);

Since a context with no dependencies can always advance to the next level.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira