[jboss-jira] [JBoss JIRA] Commented: (JBRULES-1715) function boundaries are not detected corretly when importing drl files

[Toni Rikkola (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBRULES-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12425944#action_12425944 ] 

Toni Rikkola commented on JBRULES-1715:
---------------------------------------

Talked with this in irc, I hope that this explains it.

Looks like this one is fixed since the ClassicDRLImporter class has a check that does 

if ( line.trim().startsWith( end ) ) {
                break;
}

However, I can see how this kind of check does not cover the following functions.

The curly bracket is on the same line:
function String goo1() {	return "hello";  }

if, switch or similar code block:
function void goo1() {	
    if(true){
        return "hello";
    } // <- stops here
} // <- should stop here

> function boundaries are not detected corretly when importing drl files
> ----------------------------------------------------------------------
>
>                 Key: JBRULES-1715
>                 URL: https://jira.jboss.org/jira/browse/JBRULES-1715
>             Project: JBoss Drools
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: drools-brms
>    Affects Versions: 4.0.7
>            Reporter: Seegler Ittyavirah
>            Assignee: Toni Rikkola
>
> create a drl file with some function definitions
> function definitions are seperated by opening and closing brackets-"function name(){...}"
> lets have some comments within the function with closing bracket in it -//test closing } 
> import this drl file
> drl import parser will wrongly detect the closing bracket in the comment as the end of function.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira