[jboss-jira] [JBoss JIRA] Commented: (JBAS-5626) Fix org.jboss.test.web.* tests

[Jeff Zhang (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBAS-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12425964#action_12425964 ] 

Jeff Zhang commented on JBAS-5626:
----------------------------------

last fix was fail since servlet 2.5 Cookie.java disallow "comment" attribute:
    public Cookie(String name, String value) {
	if (!isToken(name)
		|| name.equalsIgnoreCase("Comment")	// rfc2019
...
		|| name.startsWith("$")
	    ) {
	    String errMsg = lStrings.getString("err.cookie_name_is_token");
	    Object[] errArgs = new Object[1];
	    errArgs[0] = name;
	    errMsg = MessageFormat.format(errMsg, errArgs);
	    throw new IllegalArgumentException(errMsg);
	}
...
    }
So I disable "comment" attribute in the cookie for test passing, I will read the servlet 2.5 spec and RFC2109 if got time and re-fix this issue again

> Fix org.jboss.test.web.* tests
> ------------------------------
>
>                 Key: JBAS-5626
>                 URL: https://jira.jboss.org/jira/browse/JBAS-5626
>             Project: JBoss Application Server
>          Issue Type: Sub-task
>      Security Level: Public(Everyone can see) 
>          Components: Test Suite
>            Reporter: Dimitris Andreadis
>            Assignee: Jeff Zhang
>             Fix For: JBossAS-5.0.0.CR2
>
>
> http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-5.0.x-TestSuite-sun15/653/testReport/
> Plenty of org.jboss.test.web.test.* tests to try and fix!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira