[jboss-jira] [JBoss JIRA] Commented: (JBAS-5054) tests-jacc-security failures

[Dimitris Andreadis (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBAS-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12426165#action_12426165 ] 

Dimitris Andreadis commented on JBAS-5054:
------------------------------------------

I had a quick look and the test looks badly written, e.g.:

org.jboss.test.security.test.EJBSpecUnitTestCase:614

      log.debug("Sent msg to queue/QueueA");
      queueConn.start();
      QueueReceiver recv = session.createReceiver(queB);
      msg = recv.receive(5000);
      log.debug("Recv msg: "+msg);
      String info = msg.getStringProperty("reply");
      recv.close();
      session.close();
      queueConn.close();

If for some reason recv.receive(5000) times-out, then it returns null and you get an NPE so the session is not closed properly as in:
http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-5.0.x-TestSuite-sun15/837/testReport/org.jboss.test.security.test/EJBSpecUnitTestCase(tests-security-basic-unit)/testMDBRunAs/

Can you improve the test so the timeout is increased and proper cleanup is made in all cases?

> tests-jacc-security failures
> ----------------------------
>
>                 Key: JBAS-5054
>                 URL: https://jira.jboss.org/jira/browse/JBAS-5054
>             Project: JBoss Application Server
>          Issue Type: Sub-task
>      Security Level: Public(Everyone can see) 
>          Components: Security
>            Reporter: Scott M Stark
>            Assignee: Stefan Guilhen
>            Priority: Critical
>             Fix For: JBossAS-5.0.0.CR2
>
>         Attachments: server.log.zip
>
>
> There are many failures in the tests-jacc-security target.
>     [junit] Running org.jboss.test.cmp2.audit.test.AuditUnitTestCase
>     [junit] Tests run: 7, Failures: 0, Errors: 7, Time elapsed: 9.904 sec
>     [junit] Test org.jboss.test.cmp2.audit.test.AuditUnitTestCase FAILED
>     [junit] Running org.jboss.test.jacc.test.CallerInRoleUnitTestCase
>     [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0.8 sec
>     [junit] Test org.jboss.test.jacc.test.CallerInRoleUnitTestCase FAILED
>     [junit] Running org.jboss.test.jacc.test.EJBSpecUnitTestCase
>     [junit] Tests run: 23, Failures: 2, Errors: 20, Time elapsed: 21.539 sec
>     [junit] Test org.jboss.test.jacc.test.EJBSpecUnitTestCase FAILED
>     [junit] Running org.jboss.test.jacc.test.FormAuthUnitTestCase
>     [junit] Tests run: 5, Failures: 5, Errors: 0, Time elapsed: 1.088 sec
>     [junit] Test org.jboss.test.jacc.test.FormAuthUnitTestCase FAILED
>     [junit] Running org.jboss.test.jacc.test.MissingMethodUnitTestCase
>     [junit] Tests run: 2, Failures: 0, Errors: 2, Time elapsed: 0.948 sec
>     [junit] Test org.jboss.test.jacc.test.MissingMethodUnitTestCase FAILED
>     [junit] Running org.jboss.test.jacc.test.WebConstraintsUnitTestCase
>     [junit] Tests run: 4, Failures: 0, Errors: 3, Time elapsed: 10.921 sec
>     [junit] Test org.jboss.test.jacc.test.WebConstraintsUnitTestCase FAILED
>     [junit] Running org.jboss.test.jacc.test.WebIntegrationUnitTestCase
>     [junit] Tests run: 0, Failures: 0, Errors: 1, Time elapsed: 2.376 sec
>     [junit] Test org.jboss.test.jacc.test.WebIntegrationUnitTestCase FAILED
>     [junit] Running org.jboss.test.web.test.UserInRoleUnitTestCase
>     [junit] Tests run: 4, Failures: 0, Errors: 1, Time elapsed: 1.123 sec
>     [junit] Test org.jboss.test.web.test.UserInRoleUnitTestCase FAILED
>     [junit] Running org.jboss.test.webservice.jbws309.JBWS309TestCase
>     [junit] Tests run: 5, Failures: 3, Errors: 2, Time elapsed: 8.61 sec
>     [junit] Test org.jboss.test.webservice.jbws309.JBWS309TestCase FAILED

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira