[jboss-jira] [JBoss JIRA] Commented: (JBAS-4192) Evaluate having ProxyFactoryFinderInterceptor clear the ProxyFactory ThreadLocal on request exit

[Brian Stansberry (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBAS-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12426769#action_12426769 ] 

Brian Stansberry commented on JBAS-4192:
----------------------------------------

LOL. I had a feeling this would happen some day. :-)  I really have no idea if changing this will have some subtle effect, although I doubt it.  But, leaking the ProxyFactory to the thread is wrong, so I'm going to clear the ThreadLocal and count on the testsuite to tell me if there's some subtlety I'm missing.

> Evaluate having ProxyFactoryFinderInterceptor clear the ProxyFactory ThreadLocal on request exit
> ------------------------------------------------------------------------------------------------
>
>                 Key: JBAS-4192
>                 URL: https://jira.jboss.org/jira/browse/JBAS-4192
>             Project: JBoss Application Server
>          Issue Type: Sub-task
>      Security Level: Public(Everyone can see) 
>          Components: EJB2
>    Affects Versions: JBossAS-5.0.0.Beta1, JBossAS-4.2.0.CR1
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>             Fix For: JBossAS-5.0.0.CR2
>
>
> On the way in, ProxyFactoryFinderInterceptor invokes Container.setProxyFactory, which in turn sets a ThreadLocal.  On the way out there is no corresponding call that clears the ThreadLocal.  Effect is the ProxyFactory leaks to the thread.
> Need to confirm that clearing the TL on each request doesn't cause issues.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira