[jboss-jira] [JBoss JIRA] Commented: (JGRP-871) ContextObjectInputStream caches classes, potentially causing classloader leaks

[Bela Ban (JIRA)]

    [ https://jira.jboss.org/jira/browse/JGRP-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12441595#action_12441595 ] 

Bela Ban commented on JGRP-871:
-------------------------------

>> Sounds reasonable.

I removed ContextObjectInputStream


>> I think additionally deprecating the non-recommended methods might make sense. Actually, because getObject in Message 
>> says "not recommended", I thought these Util.objectXXX methods were the recommended way, because they are mentioned in 
>> the manual.

No, I don't want to deprecate them because they're still nice syntactic sugar for folks who don't care about performance, and simply want to pass in serializable objects...


>> Also, this means Channel.send(Address dst, Address src, Serializable obj) should not be used (deprecate it too?). 

No, same as above. 

>> Perhaps adding Channel.send(Address dst, Address src, byte[] data) might make sense?

No, I don't want to add more methods to the API

>> What I mean is that currently finding out what the recommended way is and using that is bit difficult. :)

Look at the demos/unit tests etc and the usage becomes quite clear.

I'm closing this case, for a further discussion please post to the jg-dev mailing list.
Cheers,


> ContextObjectInputStream caches classes, potentially causing classloader leaks
> ------------------------------------------------------------------------------
>
>                 Key: JGRP-871
>                 URL: https://jira.jboss.org/jira/browse/JGRP-871
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 2.7
>         Environment: all
>            Reporter: Sei Syvalta
>            Assignee: Bela Ban
>             Fix For: 2.7
>
>
> If jgroups is installed at application server lib directory, a classloader leak will occur. When web app is undeployed, static classCache in ContextObjectInputStream will still refer those web app classes preventing web app to undeploy properly.
> I think proper fix would be to remove this caching completely.
> Additionally, it might be worth to check the current version form jboss: http://fisheye.jboss.org/browse/JBossCommon/common-core/trunk/src/main/java/org/jboss/util/stream/MarshalledValueInputStream.java#2904. It has some fixes for java 6.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira