[jboss-jira] [JBoss JIRA] Commented: (JBPORTAL-2262) wrong instance id for portlet instances under portlet instances tab in admin ui

[Thomas Heute (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBPORTAL-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12443067#action_12443067 ] 

Thomas Heute commented on JBPORTAL-2262:
----------------------------------------

It looks like the component ids are cached, which looks like a JSF bug here...

In:
  <h:commandLink action="#{instancemgr.selectInstance}" styleClass="actionSecurity" id="security-#{instance.id}">
                     <f:param name="id" value="#{instance.id}"/>
                     <f:param name="plugin" value="security"/>
                     #{bundle.SECURITY}
                  </h:commandLink>

In
<f:param name="id" value="#{instance.id}"/>
#{instance.id} return the correct id
and in
<h:commandLink action="#{instancemgr.selectInstance}" styleClass="actionSecurity" id="security-#{instance.id}">
#{instance.id} doesn't return the correct id...

> wrong instance id for portlet instances under portlet instances  tab in admin ui
> --------------------------------------------------------------------------------
>
>                 Key: JBPORTAL-2262
>                 URL: https://jira.jboss.org/jira/browse/JBPORTAL-2262
>             Project: JBoss Portal
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Portal Core Admin
>    Affects Versions: 2.6.7 Final, 2.7.0 Final
>            Reporter: Prabhat Jha
>            Assignee: Thomas Heute
>             Fix For: 2.7.1 Final, 2.6.8 Final
>
>
> Viliam pointed this out and I thought it could be because of my id changes but it does not seem to be the case.
> For AdminPortletInstance (first page in pagination), this is what gets generated for security link
> <td><a id="jbpns_2fadmin_2fdefault_2fAdminPortletWindowsnpbj:_viewRoot:instances-form:security-AdminPortletInstance" href="#" onclick="if(typeof jsfcljs == 'function'){jsfcljs(document.getElementById('jbpns_2fadmin_2fdefault_2fAdminPortletWindowsnpbj:_viewRoot:instances-form'),{'jbpns_2fadmin_2fdefault_2fAdminPortletWindowsnpbj:_viewRoot:instances-form:security-AdminPortletInstance':'jbpns_2fadmin_2fdefault_2fAdminPortletWindowsnpbj:_viewRoot:instances-form:security-AdminPortletInstance','id':'AdminPortletInstance','plugin':'security'},'');}return false" class="actionSecurity">
>                      Security</a></td>
> For TestPortletInstance (last page in pagination), for the security link, this is what gets generated:
> <td><a id="jbpns_2fadmin_2fdefault_2fAdminPortletWindowsnpbj:_viewRoot:instances-form:security-AdminPortletInstance" href="#" onclick="if(typeof jsfcljs == 'function'){jsfcljs(document.getElementById('jbpns_2fadmin_2fdefault_2fAdminPortletWindowsnpbj:_viewRoot:instances-form'),{'jbpns_2fadmin_2fdefault_2fAdminPortletWindowsnpbj:_viewRoot:instances-form:security-AdminPortletInstance':'jbpns_2fadmin_2fdefault_2fAdminPortletWindowsnpbj:_viewRoot:instances-form:security-AdminPortletInstance','id':'TestPortletInstance','plugin':'security'},'');}return false" class="actionSecurity">
>     Security</a></td>
> The above is generated by following in instances.xhtml:
>   <h:commandLink action="#{instancemgr.selectInstance}" styleClass="actionSecurity" id="security-#{instance.id}">
>                      <f:param name="id" value="#{instance.id}"/>
>                      <f:param name="plugin" value="security"/>
>                      #{bundle.SECURITY}
>                   </h:commandLink>
> As you can see both of these have same instance.id although they are different protlet instances. Instance id seem to be getting messed up when paginating.
> To reproduce, do this:
> 1. admin -> admin -> portlet instances:
> 2. use firebug or anything to check the ids for the "security buttons" - ids are named similiar to "instance id" row name (1st - *adminportlet, 2nd - *asyncUrl,...), due to the name of used instance
> 3. click on "20" link to go to the second page
> 4. the portlet instances on the second page are other than before, but... the ids for the "security" action links are the same (1st - *adminportlet, 2nd - *asyncUrl,...).
> 5. the situation remains the same for the "40" page

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira