[jboss-jira] [JBoss JIRA] Updated: (JBPORTAL-1874) Default installation of JBoss Portal 2.6.3 does not validate as correct XHTML and CSS

Tue Feb 19 05:16:27 EST 2008

     [ http://jira.jboss.com/jira/browse/JBPORTAL-1874?page=all ]

Piotr Kubowicz updated JBPORTAL-1874:
-------------------------------------

    Attachment: fixdiv.patch

DivDecorationRenderer.java inserts wrong HTML: it closes divs which have not been opened.

> Default installation of JBoss Portal 2.6.3 does not validate as correct XHTML and CSS
> -------------------------------------------------------------------------------------
>
>                 Key: JBPORTAL-1874
>                 URL: http://jira.jboss.com/jira/browse/JBPORTAL-1874
>             Project: JBoss Portal
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Portal Core
>    Affects Versions: 2.6.3 Final
>         Environment: Windows XP SP 2, Java 6u3, JBoss 4.2.2 GA
>            Reporter: Piotr Kubowicz
>         Assigned To: Thomas Heute
>             Fix For: 2.6.5 Final
>
>         Attachments: fixdiv.patch, morevalid.patch
>
>
> After deploying downloaded JBoss Portal 2.6.3, the main page does not pass validation with http://validator.w3.org/ and http://jigsaw.w3.org/css-validator/. As result, some browsers may not display parts of pages (since they are invalid). Also other themes and layouts provided by default suffer from incompatibility with XHTML and CSS standards.
> Anyone can see this running the validator on public portal demo (there are more error messages when you log in and then run the validation).
> There are too many reasons to enumerate, but some of them include:
> - index.jsp in generic layout includes "/layouts/common/modal.jsp", which causes CSS stylesheet usage declaration (<link rel="stylesheet") being pasted inside <body> tag (sic!!!)
> - in URLs there are plain ampersand signs (IdentityUserPortletWindow?action=1&org.apache.myfaces), whilst all of them should be changed to &amp; entities
> - omitting alt attribute and closing / in <img> element in standard portlets
> - duplicate id attribute inserted by one of portlets on the main page (not visible in the demo)
> In default Renaissance theme CSS (http://skocz.pl/jbosscsserrors):
> - using "font: 11px" instead of "font-size: 11px"
> - illegal combination "background-color: none"
> I suggest including phase of XHTML and CSS validation in JBoss Portal development lifecycle because you will encounter such problems with every new release as good Java programmers need not to be good web designers. Besides W3C validators, watch output of the error console in your browser (Opera and Firefox do their job well), since it displays errors in all CSS files used on page, not only in the main CSS, as well as JavaScript errors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira