[jboss-jira] [JBoss JIRA] Resolved: (JBAS-5074) MarshalledInvocation constructor should copy over all invocation attributes

[Galder Zamarreno (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBAS-5074?page=all ]

Galder Zamarreno resolved JBAS-5074.
------------------------------------

    Fix Version/s: JBossAS-5.0.0.Beta4
       Resolution: Done

> MarshalledInvocation constructor should copy over all invocation attributes
> ---------------------------------------------------------------------------
>
>                 Key: JBAS-5074
>                 URL: http://jira.jboss.com/jira/browse/JBAS-5074
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: EJB2
>    Affects Versions: JBossAS-5.0.0.Beta2
>            Reporter: Galder Zamarreno
>         Assigned To: Galder Zamarreno
>            Priority: Minor
>             Fix For: JBossAS-5.0.0.Beta4
>
>
> trunk and 4.2.x differ slightly when it comes to org.jboss.invocation.MarshalledInvocation class.
> in 4.2.x, MarshalledInvocation(Invocation invocation) constructor does:
> ...
> this.transient_payload = invocation.transient_payload;
> this.invocationContext = invocation.invocationContext;
> ...
> whereas in trunk, the transient payload is not copied over to the MarshalledInvocation.
> The discrepancy comes from:
> http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/branches/Branch_4_2/server/src/main/org/jboss/invocation/MarshalledInvocation.java?r1=38132&r2=41001
> as part of:
> "JBAS-2436 - Commiting Pluggable Serialization into JBAS 4.0" (http://jira.jboss.com/jira/browse/JBAS-2436) 
> Brian:
> "The values should be copied. Without them the Invocation API contract cannot be properly met (e.g. Invocation.getInvocationContext(), Invocation.getTransientValue()).
> Maybe those methods are never called (except, I guess, now they are called in your tests ;)) but they are part of the API and properly supporting the API is worth the cost of a couple of assignment operations."

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira