[jboss-jira] [JBoss JIRA] Commented: (JBRULES-1426) NPE in ObjectFactory$ObjectEqualsComparator

[Alexandre Gattiker (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBRULES-1426?page=comments#action_12395433 ] 
            
Alexandre Gattiker commented on JBRULES-1426:
---------------------------------------------

Drools version: 4.0.4.
I couldn't readily create a simple unit test that demonstrates the bug.

Stack trace:

java.lang.NullPointerException
	at org.drools.base.evaluators.ObjectFactory$ObjectEqualsComparator.equals(ObjectFactory.java(Compiled Code))
	at org.drools.base.evaluators.ObjectFactory$ObjectNotEqualEvaluator.evaluate(ObjectFactory.java:158)
	at org.drools.rule.LiteralRestriction.isAllowed(LiteralRestriction.java:61)
	at org.drools.rule.LiteralConstraint.isAllowed(LiteralConstraint.java:82)
	at org.drools.reteoo.AlphaNode.assertObject(AlphaNode.java:132)
	at org.drools.reteoo.CompositeObjectSinkAdapter.propagateAssertObject(CompositeObjectSinkAdapter.java(Compiled Code))
	at org.drools.reteoo.AlphaNode.assertObject(AlphaNode.java:140)
	at org.drools.reteoo.CompositeObjectSinkAdapter.propagateAssertObject(CompositeObjectSinkAdapter.java(Compiled Code))
	at org.drools.reteoo.ObjectTypeNode.assertObject(ObjectTypeNode.java(Compiled Code))
	at org.drools.reteoo.Rete.assertObject(Rete.java(Compiled Code))
	at org.drools.reteoo.ReteooRuleBase.assertObject(ReteooRuleBase.java:192)
	at org.drools.reteoo.ReteooWorkingMemory.doInsert(ReteooWorkingMemory.java:71)
	at org.drools.common.AbstractWorkingMemory.update(AbstractWorkingMemory.java:1291)
	at org.drools.common.AbstractWorkingMemory.update(AbstractWorkingMemory.java:1209)
	at org.drools.common.AbstractWorkingMemory.propertyChange(AbstractWorkingMemory.java:1400)
	at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:265)
...


Suggested fix:
            if ( arg0 == null ) {
                return arg1 == null;
            }
            if ( arg1 == null ) {
                return false;
            }

> NPE in ObjectFactory$ObjectEqualsComparator
> -------------------------------------------
>
>                 Key: JBRULES-1426
>                 URL: http://jira.jboss.com/jira/browse/JBRULES-1426
>             Project: JBoss Drools
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>            Reporter: Alexandre Gattiker
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira