[jboss-jira] [JBoss JIRA] Commented: (JBREM-895) MicroSocketClientInvoker.transport() must check for timeout after invocation attempt.

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-895?page=comments#action_12395868 ] 
            
Ron Sigal commented on JBREM-895:
---------------------------------

Added test for per invocation timeout in transport().

org.jboss.test.remoting.callback.pull.CallbackPollerShutdownTestCase will serve as unit test.

Waiting for  hudson results.

> MicroSocketClientInvoker.transport() must check for timeout after invocation attempt.
> -------------------------------------------------------------------------------------
>
>                 Key: JBREM-895
>                 URL: http://jira.jboss.com/jira/browse/JBREM-895
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.2.2.SP4
>            Reporter: Ron Sigal
>         Assigned To: Ron Sigal
>             Fix For: 2.4.0.Beta1 (Pinto)
>
>
> Unit test org.jboss.test.remoting.callback.pull.CallbackPollerShutdownTestCase revealed a bug in org.jboss.remoting.transport.socket.MicroSocketClientInvoker.transport().  After the invocation attempt loop, there is a test to see if numberOfCallRetries has been exceeded.  If so, the semaphore has already been released, and an exception is thrown.  Another way the loop could end unsuccessfully is if a per invocation timeout has occurred.  Currently, there is no test for this condition, so that semaphore.release() is called again, increasing the semaphore counter incorrectly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira