[jboss-jira] [JBoss JIRA] Created: (JBAS-5168) Deployers conflict on .sar extension

[jean deruelle (JIRA)]

Deployers conflict on .sar extension
------------------------------------

                 Key: JBAS-5168
                 URL: http://jira.jboss.com/jira/browse/JBAS-5168
             Project: JBoss Application Server
          Issue Type: Feature Request
      Security Level: Public (Everyone can see)
          Components: Deployment services
    Affects Versions: JBossAS-4.2.2.GA
            Reporter: jean deruelle
         Assigned To: Dimitris Andreadis


We are currently building a sip servlets (JSR 289) implementation that aims to be able to run both on top of Tomcat and Jboss. (available at https://sip-servlets.dev.java.net/)
Unfortunately for us, the specs mandates that compliant containers should be able to deploy sip servlets bundled as a sar archive (.sar extension, same as jboss service archive extension). A valid sar file should contain a sip.xml in its WEB-INF directory.

This requirement made me look into Jboss AS 4.2.2.GA code and I found that the current SARDeployer will accept any file with .sar extension (in its accepts method, actually through the SubDeployerSupport accepts method). However if the sar file deployed doesn't contain a META-INF/jboss-service.xml it will fail to deploy.

This prevents us to provide our custom Tomcat Deployer to deploy sip servlet archive file (sar file with a sip.xml)

We have a proposition to correct the situation so that we can use Jboss as a sip servlets converged container :

Provide an accepts method in SARDeployer that enforce checks to see if the sar file contains a META-INF/jboss-service.xml. If not the method would return false and won't accept the deployment, leaving it for our sip servlets deployer to process and accept since it will contain a sip.xml. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira