[jboss-jira] [JBoss JIRA] Commented: (JBPORTAL-1832) -object.xml files should be orderable

[Sylvain FRANCOIS (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBPORTAL-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12422181#action_12422181 ] 

Sylvain FRANCOIS commented on JBPORTAL-1832:
--------------------------------------------

It's a simple way to resolve problem without patching JBP, but it has at least 3 drawbacks :

- XML entity inclusions using SYSTEM paths is not recommended in webapps, since you can't guarantee paths on the deployed webapp, it only works under some conditions (e.g. you assume in your example that webapp will be deployed in 'default' configuration)
- included files are not valid XML files (no prolog, possibly several roots if you want group some <deployement> nodes)
- since you can't define schemas for includes files, you lose editing facilites provided by IDE, such as completion or validation

However, it's nice to propose this solution because it may be enough for some cases.

> -object.xml files should be orderable
> -------------------------------------
>
>                 Key: JBPORTAL-1832
>                 URL: https://jira.jboss.org/jira/browse/JBPORTAL-1832
>             Project: JBoss Portal
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.6.2 Final
>            Reporter: Sylvain FRANCOIS
>         Attachments: awaysubone-object.xml, awaysubtwo-object.xml, helloworld-object.xml, homesubone-object.xml, homesubtwo-object.xml
>
>
> -object.xml files are loaded without any order rule. This makes mangement of portal/page definitions very difficult with "overwrite" mode since you can't assume if parent has already been loaded or not.
> It should be easy to fix this (I've made a temporary patch) : descriptors URL are already sorted before parsing, but their parsing results are put in a non-sorted Map (cf. org.jboss.portal.server.deployment.jboss.PortalDeploymentInfoContext). 
> PS : my -object.xml files follow this structure (all with 'overwrite' mode) :
> portal-object.xml
> toppage-x-object.xml (with all its subpages)
> toppage-y-object.xml (with all its subpages)
> toppage-z-object.xml (with all its subpages)
> ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira