[jboss-jira] [JBoss JIRA] Resolved: (JBPORTAL-1832) -object.xml files should be orderable

[Thomas Heute (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBPORTAL-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Heute resolved JBPORTAL-1832.
------------------------------------

    Fix Version/s: 2.6.6 Final
                   2.7.0 Beta1
       Resolution: Done
         Assignee: Thomas Heute


I applied it on 2.6.6 (I shouldn't have, but since the popularity of this JIRA I decided to go ahead ;) ), Branch 2.6 and Branch 2.7.

Thanks a lot for the patch, i took some liberty to modify it a bit, which won't change the overall behavior, it's just for consistency.

Also, to be clean regarding legal and since i'm sure you will provide more fixes in the future ;) Could you please sign the contributor agreement here:
http://www.jboss.org/contributor/

(Please only asked for JBoss Portal if you only contribute to JBoss Portal otherwise this will delay the procedure)

Thanks again !


> -object.xml files should be orderable
> -------------------------------------
>
>                 Key: JBPORTAL-1832
>                 URL: https://jira.jboss.org/jira/browse/JBPORTAL-1832
>             Project: JBoss Portal
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.6.2 Final
>            Reporter: Sylvain FRANCOIS
>            Assignee: Thomas Heute
>             Fix For: 2.6.6 Final, 2.7.0 Beta1
>
>         Attachments: awaysubone-object.xml, awaysubtwo-object.xml, helloworld-object.xml, homesubone-object.xml, homesubtwo-object.xml, PortalDeploymentInfoContext.diff
>
>
> -object.xml files are loaded without any order rule. This makes mangement of portal/page definitions very difficult with "overwrite" mode since you can't assume if parent has already been loaded or not.
> It should be easy to fix this (I've made a temporary patch) : descriptors URL are already sorted before parsing, but their parsing results are put in a non-sorted Map (cf. org.jboss.portal.server.deployment.jboss.PortalDeploymentInfoContext). 
> PS : my -object.xml files follow this structure (all with 'overwrite' mode) :
> portal-object.xml
> toppage-x-object.xml (with all its subpages)
> toppage-y-object.xml (with all its subpages)
> toppage-z-object.xml (with all its subpages)
> ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira