[jboss-jira] [JBoss JIRA] Commented: (JBMETA-81) BasicJndiBindingPolicy uses JAR name as Base

[Andrew Lee Rubinger (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBMETA-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12422440#action_12422440 ] 

Andrew Lee Rubinger commented on JBMETA-81:
-------------------------------------------

Will require AS patch:

Index: server/src/main/org/jboss/deployment/MappedReferenceMetaDataResolverDeployer.java
===================================================================
--- server/src/main/org/jboss/deployment/MappedReferenceMetaDataResolverDeployer.java	(revision 7616
1)
+++ server/src/main/org/jboss/deployment/MappedReferenceMetaDataResolverDeployer.java	(working copy)

@@ -49,6 +49,7 @@
 import org.jboss.metadata.ejb.jboss.jndipolicy.spi.DeploymentSummary;
 import org.jboss.metadata.ejb.jboss.jndipolicy.spi.EjbDeploymentSummary;
 import org.jboss.metadata.ejb.jboss.jndipolicy.spi.KnownInterfaces;
+import org.jboss.metadata.ejb.jboss.jndipolicy.spi.PackagingType;
 import org.jboss.metadata.ejb.spec.BusinessLocalsMetaData;
 import org.jboss.metadata.ejb.spec.BusinessRemotesMetaData;
 import org.jboss.metadata.javaee.spec.AnnotatedEJBReferenceMetaData;
@@ -1160,6 +1161,25 @@
       }
       dSummary.setDeploymentScopeBaseName(baseName);
       
+      /*
+       * Determine the packaging type (JAR or EAR, Standalone File not 
+       * supported by this deployer) 
+       */
+      
+      // Initialize to JAR
+      PackagingType packagingType = PackagingType.JAR;
+      
+      // Determine if EAR
+      boolean isEar = unit != unit.getTopLevel();
+      if(isEar)
+      {
+         packagingType = PackagingType.EAR;
+      }
+      
+      // Set type
+      dSummary.setPackagingType(packagingType);
+      
+      // Return
       return dSummary;
    }


> BasicJndiBindingPolicy uses JAR name as Base
> --------------------------------------------
>
>                 Key: JBMETA-81
>                 URL: https://jira.jboss.org/jira/browse/JBMETA-81
>             Project: JBoss Metadata
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 1.0.0.Beta30
>            Reporter: Andrew Lee Rubinger
>            Assignee: Andrew Lee Rubinger
>             Fix For: 1.0.0.Beta31
>
>
> Introduced by JBMETA-78, in order to fulfill http://wiki.jboss.org/wiki/DevJNDIBinding.
> Powering the "base" notion is deploymentScopeBaseName, which in the presence of a JAR, is the name of the JAR.  This should not be used as a base.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira