[jboss-jira] [JBoss JIRA] Commented: (JBPORTAL-2089) NPE with deleting a file in pending stage

[Prabhat Jha (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBPORTAL-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12422629#action_12422629 ] 

Prabhat Jha commented on JBPORTAL-2089:
---------------------------------------

Sohil and I had a chat about possible fixes with the workflow we have.  Once a file is in pending state, there are two options as far as deletion is concerned:

1. cascade delete the pending items (silent behavior and maybe could make some managers angry)
2. not allow file deletion if there are version pending to be approved/denied

If somebody has delete permission then he should be able to delete whatever he has access to.  It's manager's fault that he  gave permission to wrong person. So option 1 makes more sense and that's what the fix is going to be.

> NPE with deleting a file in pending stage
> -----------------------------------------
>
>                 Key: JBPORTAL-2089
>                 URL: https://jira.jboss.org/jira/browse/JBPORTAL-2089
>             Project: JBoss Portal
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Portal CMS
>    Affects Versions: 2.6.6 Final
>            Reporter: Prabhat Jha
>            Assignee: Sohil Shah
>             Fix For: 2.6.6 Final
>
>
> - Create a file.
> - Keep it in pending state
> - Select pending items from drop down menu
> - Click on the  the file you just created
> - Select Delete file from drop down and confirm deletion
> - Select pending items from drop down and hit approve. You will get NPE which is expected.  Once file is deleted, it should not be in any list.
> java.lang.NullPointerException
> 	at org.jboss.portal.core.cms.ui.admin.CMSAdminPortlet.internalDoView(CMSAdminPortlet.java:341)
> 	at org.jboss.portal.core.cms.ui.admin.CMSAdminPortlet.doView(CMSAdminPortlet.java:184)
> 	at org.jboss.portlet.JBossPortlet.doDispatch(JBossPortlet.java:257)
> 	at org.jboss.portlet.JBossPortlet.render(JBossPortlet.java:244)
> 	at org.jboss.portlet.JBossPortlet.render(JBossPortlet.java:390)
> 	at org.jboss.portal.portlet.impl.jsr168.PortletContainerImpl.invokeRender(PortletContainerImpl.java:483)
> 	at org.jboss.portal.portlet.impl.jsr168.PortletContainerImpl.dispatch(PortletContainerImpl.java:405)
> 	at org.jboss.portal.portlet.container.PortletContainerInvoker$1.invoke(PortletContainerInvoker.java:86)
> 	at org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:131)
> 	at org.jboss.portal.core.aspects.portlet.TransactionInterceptor.org$jboss$portal$core$aspects$portlet$TransactionInterceptor$invokeRequired$aop(TransactionInterceptor.java:106)
> 	at org.jboss.portal.core.aspects.portlet.TransactionInterceptor$invokeRequired_9103964459766407072.invokeNext(TransactionInterceptor$invokeRequired_9103964459766407072.java)
> 	at org.jboss.aspects.tx.TxPolicy.invokeInCallerTx(TxPolicy.java:126)
> 	at org.jboss.aspects.tx.TxInterceptor$Required.invoke(TxInterceptor.java:195)
> 	at org.jboss.portal.core.aspects.portlet.TransactionInterceptor$invokeRequired_9103964459766407072.invokeNext(TransactionInterceptor$invokeRequired_9103964459766407072.java)
> 	at org.jboss.aspects.tx.TxPolicy.invokeInCallerTx(TxPolicy.java:126)
> 	at org.jboss.aspects.tx.TxInterceptor$Required.invoke(TxInterceptor.java:195)
> 	at org.jboss.portal.core.aspects.portlet.TransactionInterceptor$invokeRequired_9103964459766407072.invokeNext(TransactionInterceptor$invokeRequired_9103964459766407072.java)
> 	at org.jboss.portal.core.aspects.portlet.TransactionInterceptor.invokeRequired(TransactionInterceptor.java)
> 	at org.jboss.portal.core.aspects.portlet.TransactionInterceptor.invoke(TransactionInterceptor.java:72)
> 	at org.jboss.portal.portlet.invocation.PortletInterceptor.invoke(PortletInterceptor.java:38)
> 	at org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:115)
> 	at org.jboss.portal.core.aspects.portlet.HeaderInterceptor.invoke(HeaderInterceptor.java:50)
> 	at org.jboss.portal.portlet.invocation.PortletInterceptor.invoke(PortletInterceptor.java:38)
> 	at org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:115)
> 	at org.jboss.portal.portlet.aspects.portlet.ProducerCacheInterceptor.invoke(ProducerCacheInterceptor.java:58)
> 	at org.jboss.portal.portlet.invocation.PortletInterceptor.invoke(PortletInterceptor.java:38)
> 	at org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:115)
> 	at org.jboss.portal.core.aspects.portlet.AjaxInterceptor.invoke(AjaxInterceptor

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira