[jboss-jira] [JBoss JIRA] Commented: (JBMETA-68) Decouple Transient "determine*" JNDI Logic from Object Model

[Ales Justin (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBMETA-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12423077#action_12423077 ] 

Ales Justin commented on JBMETA-68:
-----------------------------------

ProxyFactoryHelper

was:
      if (localBinding == null || localBinding.jndiBinding() != null || localBinding.jndiBinding().trim().length() == 0)
should be:
      if (localBinding == null || (localBinding.jndiBinding() != null && localBinding.jndiBinding().trim().length() == 0))

Was introduces NPE when 2nd condition is false.


> Decouple Transient "determine*" JNDI Logic from Object Model
> ------------------------------------------------------------
>
>                 Key: JBMETA-68
>                 URL: https://jira.jboss.org/jira/browse/JBMETA-68
>             Project: JBoss Metadata
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>            Reporter: Andrew Lee Rubinger
>            Assignee: Scott M Stark
>            Priority: Critical
>             Fix For: 1.0.0.Beta29
>
>         Attachments: jbmeta68-as.patch
>
>
> Current "determineResolved*JndiName()" methods, with default logic, are mixing concerns in the Object Model.  Resolution of target JNDI names should be extracted.
> Following steps to be taken:
> * Remove "determine*JndiName()" methods from JBossEnterpriseBeanMetadata and children
> * Remove ClassLoader from DeploymentSummary; this is transient anyway
> * Remove duplicated fields in EjbDeploymentSummary; these may be obtained via the beanMD instance
> * Create a JNDI Policy SPI for ResolveableJndiNameJbossEnterpriseBeanMetadata and ResolveableJndiNameJbossSessionBeanMetadata, denoting that this metadata is capable of resolving JNDI Names.
> * Implement the Resolveable* SPI Interfaces in Decorators
> * Create Helper Classes to access Resolveable*-type metadata, abstracting the cast from the caller
> * Update Unit Tests to use new grammars, allow 0% regression
> For integration with AS:
> * Create new deployer(s) to decorate metadata with Resolveable* interfaces and JNDI Binding Policies
> * Update grammars accordingly

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira