[jboss-jira] [JBoss JIRA] Commented: (JBAS-5623) JMS ActivationSpec 'acknowledgeMode' does not follow spec recommendation

Thu Jun 12 10:17:35 EDT 2008

    [ http://jira.jboss.com/jira/browse/JBAS-5623?page=comments#action_12416790 ] 

Adrian Brock commented on JBAS-5623:
------------------------------------

I've changed the title of this since this part of the spec is non-normative.

JCA 1.5 section B.2
"The following is a description of the __recommended__ set of JMS ActivationSpec JavaBean properties:"

I've re-opened for Jesper to "fix" it properly.

You can't just change these values.

Other people already make use of the documentated values:
http://wiki.jboss.org/wiki/ConfigJMSMessageListener
Just changing the accepted values breaks their configurations.

But also, it breaks our own mapping of the legacy ejb-jar.xml configuration to the jca 1.5 mechanism
which is where the original values came from:
http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/trunk/server/src/main/org/jboss/ejb/plugins/inflow/JBossJMSMessageEndpointFactory.java?revision=66933&view=markup

The correct "fix" would be accept both sets of values.

The documentation also needs updating as well.

> JMS ActivationSpec 'acknowledgeMode' does not follow spec recommendation
> ------------------------------------------------------------------------
>
>                 Key: JBAS-5623
>                 URL: http://jira.jboss.com/jira/browse/JBAS-5623
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: JCA service, JMS (JBoss Messaging)
>    Affects Versions: JBossAS-4.2.2.GA
>            Reporter: James Olsen
>         Assigned To: Jesper Pedersen
>             Fix For: JBossAS-4.2.3.GA, JBossAS-5.0.0.CR1
>
>
> org.jboss.resource.adapter.jms.inflow.JmsActivationSpec expects/uses values "DUPS_OK_ACKNOWLEDGE" and "AUTO_ACKNOWLEDGE" for 'acknowledgeMode'.
> According to the JCA 1.5 spec and as expected by third party components, the permitted values are "Auto-acknowledge" and  "Dups-ok-acknowledge".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira