[jboss-jira] [JBoss JIRA] Commented: (JBAS-5623) JMS ActivationSpec 'acknowledgeMode' does not follow spec recommendation

[Adrian Brock (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBAS-5623?page=comments#action_12416795 ] 
            
Adrian Brock commented on JBAS-5623:
------------------------------------

Never mind, I didn't read the commit very well. You do accept both values:

    public void setAcknowledgeMode(String acknowledgeMode)
    {
-      if ("DUPS_OK_ACKNOWLEDGE".equals(acknowledgeMode))
+      if ("DUPS_OK_ACKNOWLEDGE".equals(acknowledgeMode) || "Dups-ok-acknowledge".equals(acknowledgeMode))
          this.acknowledgeMode = Session.DUPS_OK_ACKNOWLEDGE;
-      else if ("AUTO_ACKNOWLEDGE".equals(acknowledgeMode))
+      else if ("AUTO_ACKNOWLEDGE".equals(acknowledgeMode) || "Auto-acknowledge".equals(acknowledgeMode))
          this.acknowledgeMode = Session.AUTO_ACKNOWLEDGE;

I've updated the WIKI page and will create a JIRA issue to change the main documentation.

> JMS ActivationSpec 'acknowledgeMode' does not follow spec recommendation
> ------------------------------------------------------------------------
>
>                 Key: JBAS-5623
>                 URL: http://jira.jboss.com/jira/browse/JBAS-5623
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: JCA service, JMS (JBoss Messaging)
>    Affects Versions: JBossAS-4.2.2.GA
>            Reporter: James Olsen
>         Assigned To: Jesper Pedersen
>             Fix For: JBossAS-4.2.3.GA, JBossAS-5.0.0.CR1
>
>
> org.jboss.resource.adapter.jms.inflow.JmsActivationSpec expects/uses values "DUPS_OK_ACKNOWLEDGE" and "AUTO_ACKNOWLEDGE" for 'acknowledgeMode'.
> According to the JCA 1.5 spec and as expected by third party components, the permitted values are "Auto-acknowledge" and  "Dups-ok-acknowledge".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira