[jboss-jira] [JBoss JIRA] Commented: (JBAOP-600) JRockitPluggableClassPreProcessor prevents jvmti agents from working with jrockit

[Erich Georg Hochmuth (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBAOP-600?page=comments#action_12417428 ] 
            
Erich Georg Hochmuth commented on JBAOP-600:
--------------------------------------------

Attached the fixed ClassPreProcessors

> JRockitPluggableClassPreProcessor prevents jvmti agents from working with jrockit
> ---------------------------------------------------------------------------------
>
>                 Key: JBAOP-600
>                 URL: http://jira.jboss.com/jira/browse/JBAOP-600
>             Project: JBoss AOP
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Aspect Library
>    Affects Versions: 1.3, 1.3.1, 1.3.3, 1.3.4, 1.3.5, 1.3.6, 1.5.0.GA, 1.5.1.GA, 1.5.2.GA, 1.5.3.GA, 1.5.4.GA, 1.5.4.SP1, 1.5.4.SP2, 1.5.5.GA, 1.5.6.GA, 2.0.0.alpha1, 2.0.0.alpha2, 2.0.0.alpha3, 2.0.0.alpha4, 2.0.0.alpha5, 2.0.0.alpha6, 2.0.0.beta1, 2.0.0.beta2, 2.0.0.CR1, 2.0.0.CR2, 2.0.0.CR3, 2.0.0.CR4, 2.0.0.CR5, 2.0.0.CR6, 2.0.0.CR7, 2.0.0.CR8, 2.0.0.CR9, 2.0.0.CR10, 2.0.0.CR11, 2.0.0.CR12
>            Reporter: Erich Georg Hochmuth
>         Attachments: JRockitClassPreProcessor.java, JRockitPluggableClassPreProcessor.java
>
>   Original Estimate: 10 minutes
>  Remaining Estimate: 10 minutes
>
> The preProcess method should return the original bytecode if the class wasn't modified, but JRockitPluggableClassPreProcessor returns null in this case.
>  
> When a jvmti agent is used with jrockit (and uses the ClassFileLoadHook to transform classes), the jvmti agent is called first to transform this class. The preProcess method is then called with the jvmti transformed bytecode. If the preProcess method returns null, the jvmti transformed bytecode is dismissed too.
> It's bad error handling in the jrockit vm, but a bug of the JRockitPluggableClassPreProcessor.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira