[jboss-jira] [JBoss JIRA] Commented: (JBAS-5678) closed jdbc connection before transaction rollback is called

[Adrian Brock (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBAS-5678?page=comments#action_12418935 ] 
            
Adrian Brock commented on JBAS-5678:
------------------------------------

"
But i think there still will be an problem after that (i have to try it tomorrow), because the connection will be closed
at jdbc level before the "container" got the exception (i think this behavior isn't changed with this bugfix or is it?) so before
the exception is propagated up to the local managed transaction. So in my opinion LocalManagedTransaction
getLocalTransaction().rollback() will fail with an exception.
"

So what? The real connection is already closed and that jdbc transaction rolled back.

More likely, is a Tx commit which will lead to getLocalTransaction().commit()
We want that to fail since there's no way we can complete the transaction with
a broken transactional resource.

If there's another related issue, it's providing some kind hack to map Oracle's incorrect
IllegalArgumentException to a proper SQLException, so we don't close
the connection unnecessarily.

But those are discussions for the forums, not this bug report.


> closed jdbc connection before transaction rollback is called
> ------------------------------------------------------------
>
>                 Key: JBAS-5678
>                 URL: http://jira.jboss.com/jira/browse/JBAS-5678
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: JCA service
>    Affects Versions: JBossAS-4.2.1.GA, JBossAS-4.2.2.GA
>            Reporter: hezimmer
>         Assigned To: Adrian Brock
>             Fix For: JBossAS-4.2.3.GA, JBossAS-5.0.0.CR1
>
>
> Database connection is closed before the transaction handler is able to initiate an rollback on this connection.
> Please take a look at forum entry: http://www.jboss.com/index.html?module=bb&op=viewtopic&t=137613
> Inside WrappedPreparedStatement method setDouble the Exception from underlying jdbc-driver is thrown. In case of this example 
> with Double.NaN as parameter value, Oracle causes an IllegalArgumentException instead of an SQLException. 
> Because of that BaseWrapperManagedConnection method connectionError is called: 
> Code: 
> void connectionError(Throwable t)
>    {
>       if (t instanceof SQLException == false || mcf.isExceptionFatal((SQLException) t))
>          broadcastConnectionError(t);
>    }	 
> This Throwable isn't an instance of SQLException so it seems to be an 
> connection error and broadcastConnectionError is called which causes 
> unregisterConnections and so the connection on jdbc level is closed 
> without rollback. Because of that the insert1 statement is commited 
> because oracle jdbc commits on close. So the transaction handling is not correct.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira