[jboss-jira] [JBoss JIRA] Commented: (JBREM-844) Put instance variable "isRemotingUserAgent" on stack in CoyoteInvoker

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-844?page=comments#action_12401522 ] 
            
Ron Sigal commented on JBREM-844:
---------------------------------

It doesn't seem likely that occasional recent failures of StressHTTPInvokerTestCase are related to this issue:

java.lang.Exception: org.jboss.remoting.CannotConnectException: Can not connect http client invoker.
	at org.jboss.test.remoting.transport.web.WebInvokerTestClient.testPostInvocationSub(WebInvokerTestClient.java:153)
	at org.jboss.test.remoting.transport.web.WebInvokerTestClient.testPostInvocation(WebInvokerTestClient.java:54)
	at org.jboss.test.remoting.transport.http.keep_alive.StressHTTPInvokerTestClient.testPostInvocation(StressHTTPInvokerTestClient.java:53)
	at org.jboss.jrunit.harness.ServerTestHarness.executeTestSuite(ServerTestHarness.java:302)
	at org.jboss.jrunit.harness.ServerTestHarness.access$000(ServerTestHarness.java:51)
	at org.jboss.jrunit.harness.ServerTestHarness$2.run(ServerTestHarness.java:225)
Caused by: org.jboss.remoting.CannotConnectException: Can not connect http client invoker.
	at org.jboss.remoting.transport.http.HTTPClientInvoker.useHttpURLConnection(HTTPClientInvoker.java:342)
	at org.jboss.remoting.transport.http.HTTPClientInvoker.transport(HTTPClientInvoker.java:142)
	at org.jboss.remoting.MicroRemoteClientInvoker.invoke(MicroRemoteClientInvoker.java:157)
	at org.jboss.remoting.Client.invoke(Client.java:1685)
	at org.jboss.remoting.Client.invoke(Client.java:589)
	at org.jboss.test.remoting.transport.web.WebInvokerTestClient.checkUserAgent(WebInvokerTestClient.java:169)
	at org.jboss.test.remoting.transport.web.WebInvokerTestClient.testPostInvocationSub(WebInvokerTestClient.java:146)
	... 20 more
Caused by: java.io.IOException: Stream closed.
	at java.net.PlainSocketImpl.available(PlainSocketImpl.java:428)
	at java.net.SocketInputStream.available(SocketInputStream.java:217)
	at java.io.BufferedInputStream.read(BufferedInputStream.java:325)
	at sun.net.www.MeteredStream.read(MeteredStream.java:116)
	at java.io.FilterInputStream.read(FilterInputStream.java:116)
	at sun.net.www.protocol.http.HttpURLConnection$HttpInputStream.read(HttpURLConnection.java:2370)
	at sun.net.www.protocol.http.HttpURLConnection$HttpInputStream.read(HttpURLConnection.java:2365)
	at org.jboss.remoting.marshal.http.HTTPUnMarshaller.read(HTTPUnMarshaller.java:132)
	at org.jboss.remoting.transport.http.HTTPClientInvoker.readResponse(HTTPClientInvoker.java:492)
	at org.jboss.remoting.transport.http.HTTPClientInvoker.useHttpURLConnection(HTTPClientInvoker.java:313)
	... 26 more

Set tomcat/jbossweb parameter maxThreads=500 in InvokerLocator in StressHTTPInvokerTestCase .

> Put instance variable "isRemotingUserAgent" on stack in CoyoteInvoker
> ---------------------------------------------------------------------
>
>                 Key: JBREM-844
>                 URL: http://jira.jboss.com/jira/browse/JBREM-844
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.4.0.Beta1 (Pinto), 2.2.2.GA_CP01, 2.2.2.SP2
>            Reporter: Ron Sigal
>         Assigned To: Ron Sigal
>             Fix For: 2.4.0.CR1 (Pinto)
>
>
> In org.jboss.remoting.transport.CoyoteInvoker, the variable "isRemotingUserAgent" is declared as an instance variable, which creates a race condition among multiple threads.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira