[jboss-jira] [JBoss JIRA] Resolved: (JGRP-662) max_bundle_size checks should only happen when bundling is enabled (either via conf file or JMX)

[Vladimir Blagojevic (JIRA)]

     [ http://jira.jboss.com/jira/browse/JGRP-662?page=all ]

Vladimir Blagojevic resolved JGRP-662.
--------------------------------------

    Resolution: Done

Fixed on HEAD(2.7)  
  
  User: vlada   
  Date: 08/03/13 22:00:18

  Modified:    src/org/jgroups/protocols TP.java

  Revision  Changes    Path
  1.180     +62 -28    JGroups/src/org/jgroups/protocols/TP.java

> max_bundle_size checks should only happen when bundling is enabled (either via conf file or JMX)
> ------------------------------------------------------------------------------------------------
>
>                 Key: JGRP-662
>                 URL: http://jira.jboss.com/jira/browse/JGRP-662
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 2.4.1 SP4
>            Reporter: Galder Zamarreno
>         Assigned To: Bela Ban
>            Priority: Minor
>             Fix For: 2.7
>
>
> If enable_bundling is disabled (false), why does JGroups read max_bundle_size and
> max_bundle_timeout values? These max values are used within TP.Blunder but this is
> not created if bundling is disabled. JGroups should only read and make the necessary
> processing for max_bundle_size and max_bundle_timeout if bundling is enabled. I'll
> fill in a JIRA for this.
> Seems like bundling could be enabled via dynamically via JMX (TPMBean). Maybe at 
> this point JGroups should read the values from the configuration file.
> Alternatively, values could have already been read even if bundling was disabled, but 
> calls like this in TP.setProperties:
>             if(bundle_size > max_bundle_size) {
>                 if(log.isErrorEnabled()) log.error("max_bundle_size (" + bundle_size +
>                         ") is greater than largest TP fragmentation size (" + max_bundle_size + ')');
>                 return false;
>             }
> Should only happen if bundling was enabled either statically or dynamically via the MBean, 
> specially since max_bundle_size value comes from a attempt to guess the maximum size of 
> a Datagram packet by sending one, which is dynamic value that could change over time.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira