[jboss-jira] [JBoss JIRA] Resolved: (JGRP-721) timeout and num_ping_requests hardcoded in Discovery

[Vladimir Blagojevic (JIRA)]

     [ http://jira.jboss.com/jira/browse/JGRP-721?page=all ]

Vladimir Blagojevic resolved JGRP-721.
--------------------------------------

    Resolution: Done

Fixed. HEAD (2.7)
  Revision  Changes    Path
  1.43      +9 -16     JGroups/src/org/jgroups/protocols/Discovery.java  

Fixed. Branch 2.6
  Revision  Changes    Path
  1.32.2.4  +6 -8      JGroups/src/org/jgroups/protocols/Discovery.java

> timeout and num_ping_requests hardcoded in Discovery
> ----------------------------------------------------
>
>                 Key: JGRP-721
>                 URL: http://jira.jboss.com/jira/browse/JGRP-721
>             Project: JGroups
>          Issue Type: Bug
>            Reporter: Michael Newcomb
>         Assigned To: Vladimir Blagojevic
>            Priority: Minor
>             Fix For: 2.6.3, 2.7
>
>   Original Estimate: 1 minute
>  Remaining Estimate: 1 minute
>
> int num_ping_requests=2;
> int num_discovery_requests=0;
> private final Set<Responses> ping_responses=new HashSet<Responses>();
> private final PingSenderTask sender=new PingSenderTask(timeout, num_ping_requests);
> num_ping_requests and timeout are used at construction time to create the PingSenderTask (which is final). The PingSenderTask uses the num_ping_requests and timeout to determine the send interval. Since the PingSenderTask doesn't ever recheck these values (it always uses the calculated interval) there is no effect upon changing these values...
> There will always only be 2 ping requests, 1 at +0ms and the other at +1500ms. It is further complicated by the fact that timeout is used in the waiting process, so if timeout < 3000ms, you run the risk of missing your second discovery response all together.
> Recommend calculating the interval with every call to PingSenderTask.start().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira