[jboss-jira] [JBoss JIRA] Updated: (JGRP-753) cache object returned from Message.getObject() (deserialization occurs on every call)

Bela Ban (JIRA) jira-events at lists.jboss.org
Mon May 12 03:06:22 EDT 2008


     [ http://jira.jboss.com/jira/browse/JGRP-753?page=all ]

Bela Ban updated JGRP-753:
--------------------------

    Fix Version/s: 2.6.3
                   2.7

This adds a pointer (4 bytes) to each message, not sure I want to do this. IMO the caller needs to cache this, not the message.

If I implement this, the Object needs to be transient in any case.

Hmm, I think I don't like this idea at all, as the byte[] buffer can be anything BUT an Object...

I'll take a look later this month

> cache object returned from Message.getObject() (deserialization occurs on every call)
> -------------------------------------------------------------------------------------
>
>                 Key: JGRP-753
>                 URL: http://jira.jboss.com/jira/browse/JGRP-753
>             Project: JGroups
>          Issue Type: Feature Request
>    Affects Versions: 2.6.2
>            Reporter: Michael Newcomb
>         Assigned To: Bela Ban
>             Fix For: 2.6.3, 2.7
>
>
> Proposed solution:
>    33     /** The payload */
>    34     private byte[]    buf=null;
>    34.1  private Object obj;
>   291     final public Object getObject() {
>   291.1     if (obj == null) {
>   292         try {
>   293             obj = Util.objectFromByteBuffer(buf, offset, length);
>   294         }
>   295         catch(Exception ex) {
>   296             throw new IllegalArgumentException(ex);
>   297         }
>   297.1      }
>   297.2     return obj;
>   298     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the jboss-jira mailing list