[jboss-jira] [JBoss JIRA] Commented: (JBAOP-560) When an AspectFactory returns null no interceptor should be added to the chain

Mon May 12 11:23:22 EDT 2008

    [ http://jira.jboss.com/jira/browse/JBAOP-560?page=comments#action_12412482 ] 

Flavia Rainone commented on JBAOP-560:
--------------------------------------

The feature is already implemented. However, the ConcurrentHashMap instances, used for storing aspect instances, are not compatible with null values.. Not storing null  aspects results in extra calls to factories. Besides representing an overhead, this might introduce a bug. Suppose that a factory returns non-null instances at every 2 times it is called. If we call this factory more than once for the same scope, it will result in an inconsistent behaviour.

I suggest storing an aspect that represents null in those tables. What do you say, Kabir?

> When an AspectFactory returns null no interceptor should be added to the chain
> ------------------------------------------------------------------------------
>
>                 Key: JBAOP-560
>                 URL: http://jira.jboss.com/jira/browse/JBAOP-560
>             Project: JBoss AOP
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.0.0.CR8
>            Reporter: Carlo de Wolf
>         Assigned To: Flavia Rainone
>             Fix For: 2.0.0.GA
>
>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira