[jboss-jira] [JBoss JIRA] Commented: (JBAS-5224) Improve AS start-up time.

[Stale Pedersen (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBAS-5224?page=comments#action_12413427 ] 
            
Stale Pedersen commented on JBAS-5224:
--------------------------------------

just to make sure i tested aop from trunk with as5 beta4:
beta4:
[ServerImpl] JBoss (Microcontainer) [5.0.0.Beta4 (build: SVNTag=JBoss_5_0_0_Beta4 date=200805202049)] Started in 25s:220ms
[ServerImpl] JBoss (Microcontainer) [5.0.0.Beta4 (build: SVNTag=JBoss_5_0_0_Beta4 date=200805202049)] Started in 24s:54ms
[ServerImpl] JBoss (Microcontainer) [5.0.0.Beta4 (build: SVNTag=JBoss_5_0_0_Beta4 date=200805202049)] Started in 26s:80ms

beat4 with aop from trunk:
[ServerImpl] JBoss (Microcontainer) [5.0.0.Beta4 (build: SVNTag=JBoss_5_0_0_Beta4 date=200805202049)] Started in 21s:263ms
[ServerImpl] JBoss (Microcontainer) [5.0.0.Beta4 (build: SVNTag=JBoss_5_0_0_Beta4 date=200805202049)] Started in 19s:233ms
[ServerImpl] JBoss (Microcontainer) [5.0.0.Beta4 (build: SVNTag=JBoss_5_0_0_Beta4 date=200805202049)] Started in 22s:415ms

ill also add two files that show the hotspost in as4 beta4 (original) and with aop from trunk. from what i can see there are other reasons for the increased startup time than aop. there are a lot more more invocations of the methods thats already the hotspots.
eg;
PathTokenizer.getTokens are called about +330k times in beta4 and ~600k times in trunk.
String.equals are called about 5million times in beta4 and +8 million times in trunk.
AbstractVirtualFileHandler.structuredFindChild has the same increase in calls as PathTokenizer.getTokens.
AbstractVirtualFileHandler.checkClosed have increased from ~1.4million calls to 3million calls
MatcherStrategy.subtypeOf have increased from 500k to 680k calls.
If you dont disagree I'll close this issue as it doesnt seem like aop is the reason for the increased startuptime. - but note that we're currently working on some changes that probably will speed up the boot time some.

> Improve AS start-up time.
> -------------------------
>
>                 Key: JBAS-5224
>                 URL: http://jira.jboss.com/jira/browse/JBAS-5224
>             Project: JBoss Application Server
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: AOP
>    Affects Versions: JBossAS-5.0.0.Beta4
>            Reporter: Dimitris Andreadis
>         Assigned To: Stale Pedersen
>            Priority: Blocker
>             Fix For: JBossAS-5.0.0.CR1
>
>         Attachments: as5_beta4_aop_from_trunk_hot_spots.html, as5_beta4_hot_spots.html, as5_hotspots_20_may.html, jboss-5.0.0.CR1-rev73379.zip
>
>
> The latest AOP 2.0.0.CR6/CR7 release increased again the boot time, due to AOP annotation processing.
> At this point it seems that additions to the MC org.jboss.metadata.spi.MetaData.isAnnotationPresent() SPI will be needed to accelerate the processing.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira