[jboss-jira] [JBoss JIRA] Updated: (JBMESSAGING-1351) Revisit flush on ClientConsumerImpl

Fri May 30 22:14:46 EDT 2008

     [ http://jira.jboss.com/jira/browse/JBMESSAGING-1351?page=all ]

Clebert Suconic updated JBMESSAGING-1351:
-----------------------------------------

    Description: 
I have fixed AcknowledgementTest right before the Alpha release.

I didn't want to change semantics of callOnMessage at this point... that's why I crated this task.

When the MessageListener is set after the messages were already received on the consumer, there is nothing checking for messages already received and flushing the buffer. 

handleMessage verifies for the handler and will send messages to the Receiver right away.. aways removing only one message from the buffer. IMO callOnMessage should be aways in loop while the buffer has available messages, but as I said for alpha I'm doing the loop only when setMessageListener is called.

This fix needs revisiting.
       Assignee: Tim Fox  (was: Clebert Suconic)

> Revisit flush on ClientConsumerImpl
> -----------------------------------
>
>                 Key: JBMESSAGING-1351
>                 URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1351
>             Project: JBoss Messaging
>          Issue Type: Bug
>    Affects Versions: 2.0.0 Alpha
>            Reporter: Clebert Suconic
>         Assigned To: Tim Fox
>             Fix For: 2.0.0 Beta
>
>
> I have fixed AcknowledgementTest right before the Alpha release.
> I didn't want to change semantics of callOnMessage at this point... that's why I crated this task.
> When the MessageListener is set after the messages were already received on the consumer, there is nothing checking for messages already received and flushing the buffer. 
> handleMessage verifies for the handler and will send messages to the Receiver right away.. aways removing only one message from the buffer. IMO callOnMessage should be aways in loop while the buffer has available messages, but as I said for alpha I'm doing the loop only when setMessageListener is called.
> This fix needs revisiting.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira