[jboss-jira] [JBoss JIRA] Reopened: (JBAS-6149) connectionMap.remove in WrapperDatasourceService never called

[Adrian Brock (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBAS-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Brock reopened JBAS-6149:
--------------------------------



You can't just reject it, this is a memory leak!

The correct thing to do is fix the isClosed() problem,
e.g. something like:

            Connection conn = (Connection) connectionMap.get(id);
            if( conn == null )
            {
+               if ("isClosed".equals(method.getName()))
+                  return true;
               throw new IllegalAccessException("Failed to find connection: "+id);
            }


> connectionMap.remove in WrapperDatasourceService never called
> -------------------------------------------------------------
>
>                 Key: JBAS-6149
>                 URL: https://jira.jboss.org/jira/browse/JBAS-6149
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: JCA service
>    Affects Versions: JBossAS-4.2.2.GA, JBossAS-4.2.3.GA
>         Environment: JBossAS 4.2.2 running on Linux with a remoting enabled Datasource. (postgres used in the environment)
>            Reporter: Ludwig Adam
>            Assignee: Jesper Pedersen
>             Fix For: JBossAS-5.0.0.GA, JBossAS-4.2.4.GA
>
>         Attachments: WrapperDataSourceService.java, WrapperDataSourceService.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> When providing remote datasources to the client WrapperDataSourceService adds a reference to a private Hashtable connectionMap.
> These references are never removed. In previous versions connectionMap.remove() has been called during the doConnectionMethod()-Method, however this is not present any longer in current versions (at least >= 4.2.2GA) for unknown reasons.
> Therefore the references to these Connections are never removed therefore the Datasources are never gc'ed therefore this is a memory leak in the heap space.
> Please see the forum reference for details.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira