[jboss-jira] [JBoss JIRA] Updated: (JBMESSAGING-1458) Code Review with Tim Fox

[Clebert Suconic (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBMESSAGING-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Clebert Suconic updated JBMESSAGING-1458:
-----------------------------------------


Results of first review:

I - ignore the whole file case is damaged on PageImpl::read and throw a big warning. (Maybe I should also look for possible transactions on that file)
II - Move onDepage from PagingManagerImpl to PageStoreImpl
III - move the private addsize to PageStore
IV: PagingStoreImpl constructor has a check on PagingManager, which can never be null
V - double check if a page could be zeroed... and depaging.size == 0 -> return null on readPage
VI - Rethink the need of GlobalDepager during the Executor task (Added a comment on JIRA)


> Code Review with Tim Fox
> ------------------------
>
>                 Key: JBMESSAGING-1458
>                 URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1458
>             Project: JBoss Messaging
>          Issue Type: Task
>            Reporter: Clebert Suconic
>            Assignee: Clebert Suconic
>             Fix For: 2.0.0 Beta
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira