[jboss-jira] [JBoss JIRA] Commented: (JBPORTAL-2182) Scripts and styles defined in *-themes.xml reordered by <p:theme />

Wed Oct 1 00:18:31 EDT 2008

    [ https://jira.jboss.org/jira/browse/JBPORTAL-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12431892#action_12431892 ] 

Andy Pemberton commented on JBPORTAL-2182:
------------------------------------------

The script/link ordering logic is in the constructor for ThemeInfo.

> Scripts and styles defined in *-themes.xml reordered by <p:theme />
> -------------------------------------------------------------------
>
>                 Key: JBPORTAL-2182
>                 URL: https://jira.jboss.org/jira/browse/JBPORTAL-2182
>             Project: JBoss Portal
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: Portal Theme
>         Environment: Mac OS X
>            Reporter: Andy Pemberton
>             Fix For: 2.6.5 Final
>
>
> When rendering the <scripts>, <styles>, and <links> defined in *-themes.xml - the <p:theme /> tag appears to reorder the elements, specifically by placing all of the <link> tags after all of the script <tags>.
> It appears as though the PortalThemeMetaDataFactory.addChild() methods pull all of the scripts and styles separately. 
> This is undesirable because theme authors should be able to control the order of their includes:
> 1) Often, the order that CSS rules are included will affect how the rules are applied.
> 2) The order of javascripts included can also affect behavior
> 3) Rendering all of the scripts before all of the link tags can be a performance problem (see: http://developer.yahoo.com/performance/rules.html#css_top)
> This is related to: https://jira.jboss.org/jira/browse/JBPORTAL-1105

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira