[jboss-jira] [JBoss JIRA] Commented: (JGRP-758) NakReceiverWindow: analyze concurrency between adding and removing of messages

[Bela Ban (JIRA)]

    [ https://jira.jboss.org/jira/browse/JGRP-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12434372#action_12434372 ] 

Bela Ban commented on JGRP-758:
-------------------------------

Both the NRW internal lock and the big lock in NAKACK are still needed. The former ensures that concurrent access doesn't violate consistecy (ie. elements added twice), the latter is used to ensure that all messages for a given sender are processed sequentially

> NakReceiverWindow: analyze concurrency between adding and removing of messages
> ------------------------------------------------------------------------------
>
>                 Key: JGRP-758
>                 URL: https://jira.jboss.org/jira/browse/JGRP-758
>             Project: JGroups
>          Issue Type: Task
>            Reporter: Bela Ban
>            Assignee: Bela Ban
>            Priority: Minor
>             Fix For: 2.7
>
>
> In NALACK, we call NRW.add() and subsequently NRW.remove(). These 2 methods acquire a NRW-internal lock, but the removal also acquires a lock by NRW.getLock() which is *not* the same as the NRW-internal lock . 
> Tasks:
> #1: make sure messages can be added and removed concurrently
> #2: Analyze use of NRW.getLock() (still needed ?)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira