[jboss-jira] [JBoss JIRA] Commented: (JGRP-837) Add failure simulation capabilities to Simulator

[Bela Ban (JIRA)]

    [ https://jira.jboss.org/jira/browse/JGRP-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12434822#action_12434822 ] 

Bela Ban commented on JGRP-837:
-------------------------------

Please commit your changes. I assume they won't affect existing unit tests, right ?
Regarding public void simulateSlowProcess(long delay), maybe we should add a randomization parameter, same for dropping of messages. I also wonder whether we cannot simply add a protocol (like DISCARD or DELAY) to a stack with Simulator, rather than simulating dropped messages in the Simulator directly ?

Regarding rebroadcasting of messages in NAKACK: let's move this issue to a separate JIRA task and discuss it from there. A member cannot cease receiving/sending messages forever, because it would get suspected and excluded, so we would have a recusrive FLUSH phase. Meaning, that if we flush {A,B,C,D} and - before the flush completes, C crashes - we'd continue the FLUSH phase, this time excluding C and reconciling messages for C. This scenario should be IMO also tested by your new simulator tests.

> Add failure simulation capabilities to Simulator 
> -------------------------------------------------
>
>                 Key: JGRP-837
>                 URL: https://jira.jboss.org/jira/browse/JGRP-837
>             Project: JGroups
>          Issue Type: Feature Request
>            Reporter: Richard Achmatowicz
>            Assignee: Richard Achmatowicz
>            Priority: Minor
>
> The Simulator can be used to test protocol layers in isolation. Multiple Simulator instances can be configured so that they model a multicast group.
> In its present state, messages are transported from one Simulator instance to another by the send_thread, which moves messages from send_queue to recv_queue in a reliable fashion.  Futhermore, all Simulators perform at the same speed. I'd like to use the Simulator to additionally simulate failures, in order to check the robustness of the protocols. In particular, i'd like to model:
> * dropped, reordered, corrupted messages
> * failed processors ('crash' failure)
> * network partitions
> * slow processes
> This JIRA issue will track progress on this and allow for discussion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira