[jboss-jira] [JBoss JIRA] Resolved: (JBAS-5921) Stopped deployments should not be visible in the Profile.getModifiedDeployments

[Scott M Stark (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBAS-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott M Stark resolved JBAS-5921.
---------------------------------

    Resolution: Done


No, there is now an allowHotDeployments flag in the DeploymentManager.loadProfile that the tests use to suspend hot deployment while running:

   /**
    * Load and associate the given profile with the DeploymentManager
    * for future operations.
    * 
    * @param key - the profile to load
    * @param allowHotDeployments - Can be used to suspend hot deployment
    * processing while working against a live server to avoid conflicts.
    * @throws Exception for any error
    */
   public void loadProfile(ProfileKey key, boolean allowHotDeployments) throws Exception;


> Stopped deployments should not be visible in the Profile.getModifiedDeployments
> -------------------------------------------------------------------------------
>
>                 Key: JBAS-5921
>                 URL: https://jira.jboss.org/jira/browse/JBAS-5921
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: ProfileService
>            Reporter: Scott M Stark
>            Assignee: Scott M Stark
>             Fix For: JBossAS-5.0.0.GA
>
>
> The cause of JBAS-5625 is a race between the HDScanner seeing the testEjb3xDeployment.jar and the test removing the jar. Its happening between stop of the deployment, and its removal. During this period it should not be exposed to the HDScanner, so there is a bug in the profile service repository/profile.getModifiedDeployments().
> 2008-09-01 01:40:55,515 DEBUG [org.jboss.profileservice.management.upload.remoting.DeployHandler] (WorkerThread#0[10.18.34.175:49212]) invoke, payload: {DeploymentTargetID=names=[testEjb3xDeployment.jar]phase=APPLICATIONcopyContent=truedescription=null, clientAddress=/10.18.34.175}, parameter: stop2008-09-01 01:40:55,515 INFO  [org.jboss.profileservice.management.upload.remoting.DeployHandler] (WorkerThread#0[10.18.34.175:49212]) Stop, [testEjb3xDeployment.jar]
> ...
> 2008-09-01 01:40:55,667 DEBUG [org.jboss.deployers.plugins.deployers.DeployersImpl] (WorkerThread#0[10.18.34.175:49212]) Fully Undeployed vfszip:/qa/services/hudson/hudson_workspace/workspace/JBoss-AS-5.0.x-TestSuite-sun15/trunk/build/output/jboss-5.0.0.CR2/server/profileservice/deploy/testEjb3xDeployment.jar
> ...
> 2008-09-01 01:40:55,701 DEBUG [org.jboss.system.server.profileservice.repository.SerializableDeploymentRepository] (HDScanner) Created deployment: AbstractVFSDeployment(testEjb3xDeployment.jar)
> ...
> 2008-09-01 01:40:55,716 DEBUG [org.jboss.profileservice.management.upload.remoting.DeployHandler] (WorkerThread#0[10.18.34.175:49214]) invoke, payload: {DeploymentTargetID=names=[testEjb3xDeployment.jar]phase=APPLICATIONcopyContent=truedescription=null, clientAddress=/10.18.34.175}, parameter: undeploy
> 2008-09-01 01:40:55,716 INFO  [org.jboss.profileservice.management.upload.remoting.DeployHandler] (WorkerThread#0[10.18.34.175:49214]) Undeploy, [testEjb3xDeployment.jar]
> 2008-09-01 01:40:55,718 INFO  [org.jboss.profileservice.management.upload.remoting.DeployHandler] (WorkerThread#0[10.18.34.175:49214]) Undeployed: testEjb3xDeployment.jar
> ...
> 2008-09-01 01:40:55,728 DEBUG [org.jboss.deployment.OptAnnotationMetaDataDeployer] (HDScanner) Error during deploy: vfszip:/qa/services/hudson/hudson_workspace/workspace/JBoss-AS-5.0.x-TestSuite-sun15/trunk/build/output/jboss-5.0.0.CR2/server/profileservice/deploy/testEjb3xDeployment.jar
> org.jboss.deployers.spi.DeploymentException: Cannot process metadata
>         at org.jboss.deployers.spi.DeploymentException.rethrowAsDeploymentException(DeploymentException.java:49)
>         at org.jboss.deployment.AnnotationMetaDataDeployer.deploy(AnnotationMetaDataDeployer.java:181)
>         at org.jboss.deployment.AnnotationMetaDataDeployer.deploy(AnnotationMetaDataDeployer.java:93)
>         at org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:169)
> ...
> Caused by: java.util.zip.ZipException: error in opening zip file
>         at java.util.zip.ZipFile.open(Native Method)
>         at java.util.zip.ZipFile.<init>(ZipFile.java:203)
>         at java.util.zip.ZipFile.<init>(ZipFile.java:234)
>         at org.jboss.virtual.plugins.context.zip.ZipFileWrapper.ensureZipFile(ZipFileWrapper.java:173)
>         at org.jboss.virtual.plugins.context.zip.ZipFileWrapper.openStream(ZipFileWrapper.java:207)
>         at org.jboss.virtual.plugins.context.zip.ZipEntryContext.openStream(ZipEntryContext.java:906)
> ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira