[jboss-jira] [JBoss JIRA] Commented: (JBAS-5972) One off for 4.0.4 - >JBAS-4870 - Redelivery flags not updated in case of JBossMQ node failure

[Jay Howell (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBAS-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12430121#action_12430121 ] 

Jay Howell commented on JBAS-5972:
----------------------------------

Steps to Test this issue:
Use https://jira.jboss.org/jira/secure/attachment/12316602/testredelivery.zip in JBAS-4870 to test this issue.

It's quite hard to write an ant unit test for this problem, because it can
only be reproduced with a server crash (rather than a clean shutdown of the server).

Attached is a simple ant project to test whether the redelivery flags are set correctly,
but it requires manual steps (step 4 below) to run the test.

1) Start JBoss
> ./run.sh
2) Send a message
> ant send
3) Receive the message in Client Acknowledge mode, but don't acknowledge (or close the session, etc. which is the same thing).
> ant receive
4) Crash the server (don't use control-c)
> kill -9 <jboss-pid>
5) Restart the server
> ./run.sh
7) Re-receive the message
> ant receive

You should see the redelivery count updated (before this fix you don't) 

> One off for 4.0.4 - >JBAS-4870 -  Redelivery flags not updated in case of JBossMQ node failure
> ----------------------------------------------------------------------------------------------
>
>                 Key: JBAS-5972
>                 URL: https://jira.jboss.org/jira/browse/JBAS-5972
>             Project: JBoss Application Server
>          Issue Type: Support Patch
>      Security Level: Public(Everyone can see) 
>          Components: JMS (JBossMQ)
>    Affects Versions: JBossAS-4.0.4.GA
>            Reporter: Jay Howell
>            Assignee: Jay Howell
>         Attachments: jbossmq-client.jar, jbossmq.jar
>
>
> Migrate changes for JBAS 4870 into 4.0.4GA
> PATCH NAME: 
>         [Not needed for the Cumulative Patch tasks]
>         JBAS-5972
> PRODUCT NAME:
>         JBoss Application Server
> VERSION:
>         4.0.4GA one off      
> SHORT DESCRIPTION: 
>         Fixes the redelivery flag problem when a server goes down
> LONG DESCRIPTION: 
> When the JBossMQ node fails with messages currently being delivered to the clients, 
> the redelivery status is not updated after the node is recovered (either locally or on a different for HAJMS).
> The issue is that the redelivery status (in the database) is not updated until the server receives the NACK
> (which it won't do if it has crashed).
> A potential fix, is to update the status early before delivering the message to the client,
> see the forum thread for more detail.
> This patch will patch any 4.0.4GA installation so that the redelivery happens correctly.  
> MANUAL INSTALL INSTRUCTIONS:
>         copy jbossmq.jar to server/${serverconf}/lib
>         copy jbossmq-client.jar to any running clients.
> COMPATIBILITY: 
>         Only works with 4.0.4GA
> DEPENDENCIES:
>         none
> SUPERSEDES:
>         none
> SUPERSEDED BY:
>         none
> CREATOR:
>        jhowell at redhat.com
> DATE:
>         [date these instructions were written]

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira