[jboss-jira] [JBoss JIRA] Commented: (JBMESSAGING-1396) Queue max size not check for transacted sends

[Tim Fox (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBMESSAGING-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12430137#action_12430137 ] 

Tim Fox commented on JBMESSAGING-1396:
--------------------------------------

(08:29:02) jbossfox: Howard_IRC: ok i'll explain this task a little more
(08:29:18) jbossfox: Howard_IRC: a max size can be configured for any queue in the config
(08:29:32) jbossfox: Howard_IRC: when messages are sent to the queue if size exceeds max size
(08:29:50) jbossfox: Howard_IRC: the message is just dropped
(08:29:56) jbossfox: Howard_IRC: see ChannelSupport:handle:
(08:29:57) jbossfox:  if (maxSize != -1 && getMessageCount() >= maxSize)
(08:29:57) jbossfox:       {
(08:29:57) jbossfox:          //Have reached maximum size - will drop message
(08:29:57) jbossfox:          log.warn(this + " has reached maximum size, " + ref + " will be dropped");
(08:29:57) jbossfox:          return null;
(08:29:57) jbossfox:       }
(08:30:14) jbossfox: Howard_IRC: this is what occurs if messages are sent *non transactionally*
(08:30:28) jbossfox: Howard_IRC: however, if you send a message transactionally to a queue, this method is not used
(08:30:37) jbossfox: Howard_IRC: so this check is never made
(08:30:45) jbossfox: Howard_IRC:  and the size can exceed max size
(08:31:20) jbossfox: Howard_IRC: when sending transactionally the ChannelSupport::InMemoryCallback class is used
(08:31:53) jbossfox: Howard_IRC: and you can see that on the aftercommit() method, messages are just added straight on the queue without a check for max size
(08:32:23) jbossfox: Howard_IRC: this task is basically to add a similar check on the commit for messages added to queue too, and write a simple test to check this

> Queue max size not check for transacted sends
> ---------------------------------------------
>
>                 Key: JBMESSAGING-1396
>                 URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1396
>             Project: JBoss Messaging
>          Issue Type: Bug
>            Reporter: Tim Fox
>            Assignee: Tim Fox
>             Fix For:  1.4.0.SP3.CP04, 1.4.1.GA
>
>
> Any queue max size is currently not being checked when transacted sends are processed at transaction commit.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira