[jboss-jira] [JBoss JIRA] Commented: (JBMESSAGING-1415) remoting-bisocket-service.xml refers to obsolete numberOfCallRetries jboss-remoting param

[Ron Sigal (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBMESSAGING-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12430907#action_12430907 ] 

Ron Sigal commented on JBMESSAGING-1415:
----------------------------------------

Addendum 1:  isParam="true" should be set, so that the parameter gets to the client

Addendum 2: It's been so long since I worked on JBM that I don't know anything about the branches, etc., so I'll let someone else commit the change.

> remoting-bisocket-service.xml refers to obsolete numberOfCallRetries jboss-remoting param
> -----------------------------------------------------------------------------------------
>
>                 Key: JBMESSAGING-1415
>                 URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1415
>             Project: JBoss Messaging
>          Issue Type: Task
>          Components: AS Integration
>    Affects Versions: 1.4.1.CR1
>            Reporter: Dimitris Andreadis
>            Assignee: Ron Sigal
>             Fix For:  1.4.0.SP3.CP04, 1.4.1.GA
>
>
> With the upgrade of jboss remoting to 2.4.0.SP1 we see a warning in the AS console:
> 21:13:15,625 WARN  [MicroSocketClientInvoker] numberOfRetries is no longer used
> This is coming from setting numberOfRetries in remoting-bisocket-service.xml:
> ...
>             <invoker transport="bisocket">
>             
>                <!-- There should be no reason to change these parameters - warning!
>                     Changing them may stop JBoss Messaging working correctly -->            
>                <attribute name="marshaller" isParam="true">org.jboss.jms.wireformat.JMSWireFormat</attribute>
>                <attribute name="unmarshaller" isParam="true">org.jboss.jms.wireformat.JMSWireFormat</attribute>
>                <attribute name="dataType" isParam="true">jms</attribute>
>                <attribute name="socket.check_connection" isParam="true">false</attribute>               
>                <attribute name="serverBindAddress">${jboss.bind.address}</attribute>
>                <attribute name="serverBindPort">4457</attribute>
>                <attribute name="clientSocketClass" isParam="true">org.jboss.jms.client.remoting.ClientSocketWrapper</attribute>
>                <attribute name="serverSocketClass">org.jboss.jms.server.remoting.ServerSocketWrapper</attribute>
> 	       
>                <attribute name="numberOfCallRetries" isParam="true">1</attribute>
>                <attribute name="pingFrequency" isParam="true">214748364</attribute>
>                <attribute name="pingWindowFactor" isParam="true">10</attribute>
>                <attribute name="onewayThreadPool">org.jboss.jms.server.remoting.DirectThreadPool</attribute>
> ...
> It should be removed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira