[jboss-jira] [JBoss JIRA] Commented: (JBAS-6718) AS5 plugin: If the "use-java-context" property is left unset when creating a datasource, it now gets set to "false" by default instead of to "true"

[Scott M Stark (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBAS-6718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12460167#action_12460167 ] 

Scott M Stark commented on JBAS-6718:
-------------------------------------

I'm not seeing this. If I comment out the setting of the use-java-context in the ProfileServivceUnitTestCase.testAddDataSource, I do see the use-java-context set to true:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<datasources>
    <local-tx-datasource>
        <jndi-name>TestLocalTxDs</jndi-name>
        <rar-name>jboss-local-jdbc.rar</rar-name>
        <use-java-context>true</use-java-context>
...

This is the default value in the template as well:
   static
   {
      // populate the default values
      defaultValues.put("use-java-context", new SimpleValueSupport(SimpleMetaType.BOOLEAN_PRIMITIVE, true));
      defaultValues.put("min-pool-size", new SimpleValueSupport(SimpleMetaType.INTEGER_PRIMITIVE, 0));
      defaultValues.put("max-pool-size", new SimpleValueSupport(SimpleMetaType.INTEGER_PRIMITIVE, 10));
      defaultValues.put("blocking-timeout-millis", new SimpleValueSupport(SimpleMetaType.LONG_PRIMITIVE, 3000));
      defaultValues.put("idle-timeout-minutes", new SimpleValueSupport(SimpleMetaType.INTEGER_PRIMITIVE, 30));
      defaultValues.put("background-validation", new SimpleValueSupport(SimpleMetaType.BOOLEAN_PRIMITIVE, false));
      defaultValues.put("background-validation-millis", new SimpleValueSupport(SimpleMetaType.LONG_PRIMITIVE, 0));
      defaultValues.put("validate-on-match", new SimpleValueSupport(SimpleMetaType.BOOLEAN_PRIMITIVE, true));
      defaultValues.put("interleaving", new SimpleValueSupport(SimpleMetaType.BOOLEAN_PRIMITIVE, false));
      defaultValues.put("allocation-retry", new SimpleValueSupport(SimpleMetaType.INTEGER_PRIMITIVE, 0));
      defaultValues.put("allocation-retry-wait-millis", new SimpleValueSupport(SimpleMetaType.INTEGER_PRIMITIVE, 5000));
      defaultValues.put("prepared-statement-cache-size", new SimpleValueSupport(SimpleMetaType.INTEGER_PRIMITIVE, 0));
      defaultValues.put("share-prepared-statements", new SimpleValueSupport(SimpleMetaType.BOOLEAN_PRIMITIVE, false));
      defaultValues.put("set-tx-query-timeout", new SimpleValueSupport(SimpleMetaType.BOOLEAN_PRIMITIVE, false));
      defaultValues.put("query-timeout", new SimpleValueSupport(SimpleMetaType.INTEGER_PRIMITIVE, 0));
   }


> AS5 plugin: If the "use-java-context" property is left unset when creating a datasource, it now gets set to "false" by default instead of to "true"
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBAS-6718
>                 URL: https://jira.jboss.org/jira/browse/JBAS-6718
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: ProfileService
>         Environment: JBoss AS Branch_5_x r86370, embjopr r256
>            Reporter: Farah Juma
>            Assignee: Scott M Stark
>            Priority: Critical
>             Fix For: JBossAS-5.1.0.CR1
>
>
> Steps to reproduce:
> Create a new datasource and leave the "Use Java Context" property unset. If you check the "use-java-context" property of the ManagedComponent or look at the -ds.xml file that was created, you'll see that "use-java-context" is set to "false". Until recently, this property was being set to "true" by default.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira