[jboss-jira] [JBoss JIRA] Updated: (JBPORTAL-2441) JBPC should not use common names for technical http parameter names

[Bernard de Terwangne (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBPORTAL-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bernard de Terwangne updated JBPORTAL-2441:
-------------------------------------------

    Attachment: ControllerRequestParameterNames.java


All http parameter names now start with "p_" and are much shorter. some samples :

phase => p_ph
publicnavigationalstatechanges => p_pnsc

I left in comments the original names just in case

> JBPC should not use common names for technical http parameter names
> -------------------------------------------------------------------
>
>                 Key: JBPORTAL-2441
>                 URL: https://jira.jboss.org/jira/browse/JBPORTAL-2441
>             Project: JBoss Portal
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: Portlet-2.0.1
>         Environment: Any
>            Reporter: Bernard de Terwangne
>         Attachments: ControllerRequestParameterNames.java
>
>
> JBoss Portlet Container uses very common parameter names such as mode, action, resource, type, portlet, ...
> Such parameter name have a high risk of conflicting with portlet specific parameter names. 
> Some names are also quite long such as "publicnavigationalstatechanges"
> I suggest to replace them with shorter and tagged names. 
> Hopefully thanks to a good coding quality the only affected class for doinig so will be org.jboss.portal.portlet.controller.impl.ControllerRequestParameterNames
> I'll attach to this ticket an improved version of this class

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira