[jboss-jira] [JBoss JIRA] Issue Comment Edited: (JBREM-1077) Fix problem in CompressingMarshaller

[Ron Sigal (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBREM-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12479117#action_12479117 ] 

Ron Sigal edited comment on JBREM-1077 at 8/5/09 3:07 PM:
----------------------------------------------------------

There's another chapter to the story.  

I noticed recently that NewCompressingMarshallerTestCase, which runs in about half a minute on my Windows laptop, takes about 13 minutes on one of the Red  Hat linux test machines.  It turns out that the GZipOutputStream constructor takes an order of magnitude longer in linux than in Windows.  I've changed CompressingMarshaller so that it reuses a single GZipOutputStream but replaces the Deflater with each call to write().  CompressingUnMarshaller has the symmetric changes with respect to Inflater.  Now NewCompressingMarshallerTestCase takes about 18 seconds on my Fedora laptop.

I've attached a copy of jboss-remoting.jar from the 2.x branch with the changes.  It will print 

  Remoting version: 2.5.2 (Flounder) preview: 8/05/09-14:49

when it is loaded.

I will port the changes to the 2.2 branch as well.

      was (Author: ron.sigal at jboss.com):
    There's another chapter to the story.  

I noticed recently that NewCompressingMarshallerTestCase, which runs in about half a minute on my Windows laptop, takes about 13 minutes on one of the Red  Hat linux test machines.  It turns out that the GZipOutputStream constructor takes an order of magnitude longer in linux than in Windows.  I've changed CompressingMarshaller so that it reuses a single GZipOutputStream but replaces the Deflater with each call to write().  CompressingUnMarshaller has the symmetric changes with respect to Inflater.  Now NewCompressingMarshallerTestCase takes about 18 seconds on my Fedora laptop.
  
> Fix problem in CompressingMarshaller
> ------------------------------------
>
>                 Key: JBREM-1077
>                 URL: https://jira.jboss.org/jira/browse/JBREM-1077
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.5.0.SP2 (Flounder) , 2.2.2.SP11
>            Reporter: Ron Sigal
>            Assignee: Ron Sigal
>             Fix For: 2.5.2 (Flounder), 2.2.3.SP1
>
>         Attachments: CompressionInvokerMarshaller.java, CompressionInvokerUnmarshaller.java, ejb3-compression.tgz, jboss-remoting.jar, jboss-remoting.jar, jboss-remoting.jar
>
>
> In org.jboss.remoting.marshal.compress.CompressingMarshaller.write(),
>       gzos.finish();
>       oos.flush();
> should be
>       oos.flush();
>       bos.flush();
>       gzos.flush();
>       gzos.finish();
> as it is on the 2.x branch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira