[jboss-jira] [JBoss JIRA] Commented: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[Andrew Lee Rubinger (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12481051#action_12481051 ] 

Andrew Lee Rubinger commented on JBBOOT-43:
-------------------------------------------

Looks like the patch generally tests the right idea.

1) Looks like you can do away with the MCServerBootstrapUrlTestCase. at After lifecycle method if you shut down the server in each test.  Actually, this should be done anyway (so that the environment is left in consistent state).  Shutdown will remove all properties set during startup.  @see AbstractBasicServerInitializer.cleanup for the impl.

2) MCServerBootstrapUrlTestCase.testNestedUrlStartsWithSlash and testBootstrapUrlStartsWithSlash are testing implementation details regarding the exception message.  Might be better to introduce a new exception type and test for instanceof.

3) Nitpicking spelling/typos? ;)  -

* AbstractMCServerBase "choldBootstrapURL" > "childBootstrapURL"
* MCServerBootstrapUrlTestCase "testBootstrapHttpUrlMiltiNested" > "testBootstrapHttpUrlMultiNested"
* MCServerBootstrapUrlTestCase "testBootstrapFileUrlMulitNested" > "testBootstrapFileUrlMultiNested"

> Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements
> ----------------------------------------------------------------------------------------------------
>
>                 Key: JBBOOT-43
>                 URL: https://jira.jboss.org/jira/browse/JBBOOT-43
>             Project: JBoss Bootstrap
>          Issue Type: Feature Request
>          Components: impl-base
>    Affects Versions: 0.1.1
>            Reporter: Andrew Lee Rubinger
>            Assignee: John Bailey
>             Fix For: Unscheduled
>
>         Attachments: JBBOOT-43.patch
>
>
> Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira