[jboss-jira] [JBoss JIRA] Closed: (JBMESSAGING-1722) MessagingQueue.mergeIn() can break the paging order.

[Howard Gao (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBMESSAGING-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard Gao closed JBMESSAGING-1722.
-----------------------------------

    Resolution: Done


The fix:

Introduce a boolean flag isFromMerge into the InitialLoadInfo class and in PagingChannelSupport.doLoad() method we check this flag. If the flag is true, meaning the loading of messages comes from Queue merging operation, it will not reset the paging status, as in the following piece of code:

         if (!ili.isFromMerge())
         {
            firstPagingOrder = nextPagingOrder = 0;
            paging = false;
         }

So the paging status of the local queue is preserved.



> MessagingQueue.mergeIn() can break the paging order.
> ----------------------------------------------------
>
>                 Key: JBMESSAGING-1722
>                 URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1722
>             Project: JBoss Messaging
>          Issue Type: Bug
>    Affects Versions: 1.4.0.SP3.CP08, 1.4.4.GA
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>             Fix For: 1.4.0.SP3.CP09, 1.4.5.GA
>
>         Attachments: test-1722.zip
>
>
> On node failover, clustered queue on the failed node will be merged into the queue on the back up node. If the local queue is in paging state but the failed queue has no messages to merge in, it will reset the firstPagingOrder and nextPagingOrder and therefore change the paging state to false. That makes the paging broken.
> This issue were found during investigating the associated ticket. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira