[jboss-jira] [JBoss JIRA] Commented: (JBMESSAGING-1728) OrderingGroupMonitor shouldn't hold any MessageReference objects that are paged

[Howard Gao (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBMESSAGING-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12483682#action_12483682 ] 

Howard Gao commented on JBMESSAGING-1728:
-----------------------------------------

Thanks Markus. You are right the place where the messages are registered with the monitor is simply wrong. By fixing this, I believe the problem is gone. What I'm doing now is let the register thing only happens when a message reference is added to the memory, whether it is directly from the new added message or from the paged DB. 

Howard


> OrderingGroupMonitor shouldn't hold any MessageReference objects that are paged
> -------------------------------------------------------------------------------
>
>                 Key: JBMESSAGING-1728
>                 URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1728
>             Project: JBoss Messaging
>          Issue Type: Bug
>          Components: Messaging Core
>    Affects Versions: 1.4.0.SP3.CP08, 1.4.4.GA
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>             Fix For: 1.4.0.SP3.CP09, 1.4.5.GA
>
>
> OrderingGroupMonitor registers ordering group messages by holding its messages. In paging mode, it will take up memories.
> We need to refactor it to:
> 1. only register in memory references.
> 2. don't hold it's reference in the OrderingGroupMonitor, only the MessageID will suffice.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira