[jboss-jira] [JBoss JIRA] Created: (JBAS-7493) StatefulSessionUnitTestCase.testBadUserTx incorrect

Jonathan Halliday (JIRA) jira-events at lists.jboss.org
Wed Dec 2 04:47:29 EST 2009


StatefulSessionUnitTestCase.testBadUserTx incorrect
---------------------------------------------------

                 Key: JBAS-7493
                 URL: https://jira.jboss.org/jira/browse/JBAS-7493
             Project: JBoss Application Server
          Issue Type: Bug
      Security Level: Public (Everyone can see)
          Components: Test Suite
    Affects Versions: JBossAS-6.0.0.M1
            Reporter: Jonathan Halliday
             Fix For: JBossAS-6.0.0.M2


org.jboss.test.cts.test.StatefulSessionUnitTestCase.testBadUserTx incorrectly uses JMX lookup of tx statistics to verify the outcome. There are two issues with this approach

1) The exposure of tx statistics is not part of the tx integration API, it's an implementation detail of the tx manager, so it should not be relied upon. Perhaps a Synchronization instead?
2) Even if it is decided to continue with this close coupling of the test suite to a component implementation, the test does not enable statistics gathering. Since this is off by default for performance reasons, the tx counter will always be 0. This may cause the test to pass in cases where it should not.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the jboss-jira mailing list