[jboss-jira] [JBoss JIRA] Closed: (JBID-227) SAML20TokenProvider cannot handle missing cancel_ids_file

[Stefan Guilhen (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBID-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Guilhen closed JBID-227.
-------------------------------

    Fix Version/s: IDFED-1.0.0.GA
       Resolution: Done


This has been spotted before and is fixed in trunk. Release 1.0.0 contains the fixed code.

> SAML20TokenProvider cannot handle missing cancel_ids_file
> ---------------------------------------------------------
>
>                 Key: JBID-227
>                 URL: https://jira.jboss.org/jira/browse/JBID-227
>             Project: JBoss Identity
>          Issue Type: Bug
>          Components: Identity-Federation
>    Affects Versions: IDFED-1.0.0.beta3
>         Environment: Windows XP SP3, JBoss 5.1.0.GA
>            Reporter: Jaap Reitsma
>            Assignee: Stefan Guilhen
>             Fix For: IDFED-1.0.0.GA
>
>
> In org.jboss.identity.federation.core.wstrust.plugins.saml.SAML20TokenProvider:
> The logic to handle a potential missing  cancel_ids_file is not correct. Instead of:
> if (file == null && logger.isDebugEnabled())
>          logger.debug("File to store canceled ids has not been specified: ids will not be persisted!");
>       else
>          ....
> the intention is probably: 
> if (file == null) {
>     	  if (logger.isDebugEnabled()) {
>    	         logger.debug("File to store canceled ids has not been specified: ids will not be persisted!");
>     	  }
>       }
>       else
>            ....

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira