[jboss-jira] [JBoss JIRA] Resolved: (JBAS-7494) TxConnectionManagerUnitTestCase has poor TransactionTimeout usage

[Shelly McGowan (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBAS-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shelly McGowan resolved JBAS-7494.
----------------------------------

    Resolution: Done


changes implemented

> TxConnectionManagerUnitTestCase has poor TransactionTimeout usage
> -----------------------------------------------------------------
>
>                 Key: JBAS-7494
>                 URL: https://jira.jboss.org/jira/browse/JBAS-7494
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Test Suite
>    Affects Versions: JBossAS-6.0.0.M1
>            Reporter: Jonathan Halliday
>            Assignee: Shelly McGowan
>             Fix For: JBossAS-6.0.0.M2
>
>
> org.jboss.test.jca.test.TxConnectionManagerUnitTestCase.setUp uses mbean lookup of a the TransactionTimeout property. This is not required to be present by the tx integration api, it's an implementation detail of the tx mgr. Hence this tests is unnecessarily fragile, especially since the only use of the value retrieved is to reset it after the test. Probably better to just call setTransactionTimeout(0) in tearDown, which will restore the default timeout.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira