[jboss-jira] [JBoss JIRA] Commented: (JBASM-28) testTimeoutStop test failure since changes to ServerController.java were implemented

[Richard Achmatowicz (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBASM-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12452614#action_12452614 ] 

Richard Achmatowicz commented on JBASM-28:
------------------------------------------

Committed changes and test pass ok:
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.jboss.jbossas.servermanager.test.startstop.unit.StartStopTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 86.279 sec
Running org.jboss.jbossas.servermanager.test.startstop.unit.FailStartStopTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 128.388 sec
Running org.jboss.jbossas.servermanager.test.startstop.unit.StartStopShutdownJarTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 86.349 sec
Running org.jboss.jbossas.servermanager.test.jmxinvocation.unit.JmxInvocationTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.121 sec

Results :

Tests run: 7, Failures: 0, Errors: 0, Skipped: 0

I realised that although I had to reintroduce the delay, I could move it out of the main line of processing where it was originally. So the delay will only be called if a process *does* need to be destroyed. 
Thus, in most cases of clean shutdown, we don't incur the 45 second delay and isRunning() and ServerController.isServerStarted() will correctly return false after ServerController.stopServer() exits.




> testTimeoutStop test failure since changes to ServerController.java were implemented
> ------------------------------------------------------------------------------------
>
>                 Key: JBASM-28
>                 URL: https://jira.jboss.org/jira/browse/JBASM-28
>             Project: JBoss AS Server Manager
>          Issue Type: Bug
>            Reporter: Shelly McGowan
>            Assignee: Richard Achmatowicz
>
> Richard, I'll have to ask you to take a look at these.    They seem to occur since the changes you've committed.  After losing the history of ServerController.java it is difficult to know what was exactly changed.  To run the tests, you will need an  JBoss AS 5 installation built as the tests start and stop the default server config.
> -------------------------------------------------------------------------------
> Test set: org.jboss.jbossas.servermanager.test.startstop.unit.FailStartStopTest
> -------------------------------------------------------------------------------
> Tests run: 3, Failures: 1, Errors: 1, Skipped: 0, Time elapsed: 107.081 sec <<< FAILURE!
> <testcase classname="org.jboss.jbossas.servermanager.test.startstop.unit.FailStartStopTest" time="107.059" name="testTimeoutStop">
>     <error type="java.lang.IllegalArgumentException" message="The default is not running; it cannot be stopped.">java.lang.IllegalArgumentException: The default is not running; it cannot be stopped.
>         at org.jboss.jbossas.servermanager.ServerController.stopServer(ServerController.java:373)
>         at org.jboss.jbossas.servermanager.test.startstop.unit.FailStartStopTest.after(FailStartStopTest.java:227)
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira