[jboss-jira] [JBoss JIRA] Commented: (JBAS-1796) Review project dependencies and create proper abstractions

[Adrian Brock (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBAS-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12452912#action_12452912 ] 

Adrian Brock commented on JBAS-1796:
------------------------------------

Come on you can do better than that. If you are going to argue, at least avoid using logical fallacies.

There's a big difference between tidying up the cruft that is known to exist in the codebase
and raising an issue that says "don't put cruft in the codebase"

"I'm closing this because no one can be bothered" isn't a reason to ignore the issue - 
"monkey see monkey do" is a good reason to remove the bad examples even if it wasn't worth doing
for its own sake.

Anyway, lets take further discussions to the mailing list.


> Review project dependencies and create proper abstractions
> ----------------------------------------------------------
>
>                 Key: JBAS-1796
>                 URL: https://jira.jboss.org/jira/browse/JBAS-1796
>             Project: JBoss Application Server
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: Other
>            Reporter: Adrian Brock
>            Priority: Critical
>             Fix For: Backlog
>
>         Attachments: 20090210.zip
>
>
> I am getting singlularly fed up with people doing their own integrations
> in such a way that every project needs to depend directly on everything
> in thirdparty and every other project.
> Some people need to go on a course to learn the meaning of abstraction.
> e.g.
> The server module is an integration project. It should not be directly dependent
> on implementation details of Xerces:
> package org.jboss.webservice.metadata.wsdl;
> import org.apache.xerces.xs.XSComplexTypeDefinition;
> import org.apache.xerces.xs.XSTypeDefinition;
> import org.jboss.webservice.metadata.wsdl.WSDLConstants;
> import org.jboss.webservice.metadata.wsdl.xsd.XSDComplexType;
> import org.jboss.webservice.metadata.wsdl.xsd.XSDElement;
> import org.jboss.webservice.metadata.wsdl.xsd.XSDSchema;
> import org.jboss.webservice.metadata.wsdl.xsd.XSDSimpleType;
> import org.jboss.webservice.metadata.wsdl.xsd.XSDType;
> import javax.xml.namespace.QName;
> import java.io.File;
> import java.io.FileWriter;
> import java.io.IOException;
> import java.lang.reflect.Field;
> import java.lang.reflect.Method;
> import java.lang.reflect.Modifier;
> import java.net.URL;
> import java.util.ArrayList;
> import java.util.HashMap;
> import java.util.Iterator;
> import java.util.List;
> import java.util.Map;
> public class WSDLUtils
> {
>    private String newline = System.getProperty("line.separator");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira